* [PATCH net v2] sunhme: Uninitialized variable in happy_meal_init()
@ 2022-10-14 14:33 Dan Carpenter
2022-10-15 0:19 ` Sean Anderson
2022-10-15 10:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2022-10-14 14:33 UTC (permalink / raw)
To: Sean Anderson
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
netdev, kernel-janitors
The "burst" string is only initialized for CONFIG_SPARC. It should be
set to "64" because that's what is used by PCI.
Fixes: 24cddbc3ef11 ("sunhme: Combine continued messages")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
v2: Use "64" instead of ""
drivers/net/ethernet/sun/sunhme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/sun/sunhme.c b/drivers/net/ethernet/sun/sunhme.c
index 62deed210a95..55f7ec836744 100644
--- a/drivers/net/ethernet/sun/sunhme.c
+++ b/drivers/net/ethernet/sun/sunhme.c
@@ -1328,7 +1328,7 @@ static int happy_meal_init(struct happy_meal *hp)
void __iomem *erxregs = hp->erxregs;
void __iomem *bregs = hp->bigmacregs;
void __iomem *tregs = hp->tcvregs;
- const char *bursts;
+ const char *bursts = "64";
u32 regtmp, rxcfg;
/* If auto-negotiation timer is running, kill it. */
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net v2] sunhme: Uninitialized variable in happy_meal_init()
2022-10-14 14:33 [PATCH net v2] sunhme: Uninitialized variable in happy_meal_init() Dan Carpenter
@ 2022-10-15 0:19 ` Sean Anderson
2022-10-15 10:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Sean Anderson @ 2022-10-15 0:19 UTC (permalink / raw)
To: Dan Carpenter
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
netdev, kernel-janitors
On 10/14/22 10:33, Dan Carpenter wrote:
> The "burst" string is only initialized for CONFIG_SPARC. It should be
> set to "64" because that's what is used by PCI.
>
> Fixes: 24cddbc3ef11 ("sunhme: Combine continued messages")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v2: Use "64" instead of ""
>
> drivers/net/ethernet/sun/sunhme.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/sun/sunhme.c b/drivers/net/ethernet/sun/sunhme.c
> index 62deed210a95..55f7ec836744 100644
> --- a/drivers/net/ethernet/sun/sunhme.c
> +++ b/drivers/net/ethernet/sun/sunhme.c
> @@ -1328,7 +1328,7 @@ static int happy_meal_init(struct happy_meal *hp)
> void __iomem *erxregs = hp->erxregs;
> void __iomem *bregs = hp->bigmacregs;
> void __iomem *tregs = hp->tcvregs;
> - const char *bursts;
> + const char *bursts = "64";
> u32 regtmp, rxcfg;
>
> /* If auto-negotiation timer is running, kill it. */
Reviewed-by: Sean Anderson <seanga2@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net v2] sunhme: Uninitialized variable in happy_meal_init()
2022-10-14 14:33 [PATCH net v2] sunhme: Uninitialized variable in happy_meal_init() Dan Carpenter
2022-10-15 0:19 ` Sean Anderson
@ 2022-10-15 10:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-10-15 10:20 UTC (permalink / raw)
To: Dan Carpenter
Cc: seanga2, davem, edumazet, kuba, pabeni, netdev, kernel-janitors
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Fri, 14 Oct 2022 17:33:02 +0300 you wrote:
> The "burst" string is only initialized for CONFIG_SPARC. It should be
> set to "64" because that's what is used by PCI.
>
> Fixes: 24cddbc3ef11 ("sunhme: Combine continued messages")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v2: Use "64" instead of ""
>
> [...]
Here is the summary with links:
- [net,v2] sunhme: Uninitialized variable in happy_meal_init()
https://git.kernel.org/netdev/net/c/9408f3d321ed
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-15 10:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-14 14:33 [PATCH net v2] sunhme: Uninitialized variable in happy_meal_init() Dan Carpenter
2022-10-15 0:19 ` Sean Anderson
2022-10-15 10:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).