netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Jiri Benc <jbenc@redhat.com>
Cc: netdev@vger.kernel.org, shmulik@metanetworks.com,
	eric.dumazet@gmail.com, tomas@tigera.io,
	jpiotrowski@linux.microsoft.com, kuba@kernel.org,
	willemdebruijn.kernel@gmail.com
Subject: Re: [PATCH net v2] net: gso: fix panic on frag_list with mixed head alloc types
Date: Fri, 04 Nov 2022 04:10:16 +0000	[thread overview]
Message-ID: <166753501670.4086.1819802414418539212.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <e04426a6a91baf4d1081e1b478c82b5de25fdf21.1667407944.git.jbenc@redhat.com>

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Wed,  2 Nov 2022 17:53:25 +0100 you wrote:
> Since commit 3dcbdb134f32 ("net: gso: Fix skb_segment splat when
> splitting gso_size mangled skb having linear-headed frag_list"), it is
> allowed to change gso_size of a GRO packet. However, that commit assumes
> that "checking the first list_skb member suffices; i.e if either of the
> list_skb members have non head_frag head, then the first one has too".
> 
> It turns out this assumption does not hold. We've seen BUG_ON being hit
> in skb_segment when skbs on the frag_list had differing head_frag with
> the vmxnet3 driver. This happens because __netdev_alloc_skb and
> __napi_alloc_skb can return a skb that is page backed or kmalloced
> depending on the requested size. As the result, the last small skb in
> the GRO packet can be kmalloced.
> 
> [...]

Here is the summary with links:
  - [net,v2] net: gso: fix panic on frag_list with mixed head alloc types
    https://git.kernel.org/netdev/net/c/9e4b7a99a03a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      parent reply	other threads:[~2022-11-04  4:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-02 16:53 [PATCH net v2] net: gso: fix panic on frag_list with mixed head alloc types Jiri Benc
2022-11-02 17:11 ` Willem de Bruijn
2022-11-04  4:10 ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=166753501670.4086.1819802414418539212.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=eric.dumazet@gmail.com \
    --cc=jbenc@redhat.com \
    --cc=jpiotrowski@linux.microsoft.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=shmulik@metanetworks.com \
    --cc=tomas@tigera.io \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).