[PATCH] drivers: net: xgene: disable napi when register irq failed in xgene_enet_open()

[PATCH] drivers: net: xgene: disable napi when register irq failed in xgene_enet_open()

[Zhengchao Shao]

When failed to register irq in xgene_enet_open() for opening device,
napi isn't disabled. When open xgene device next time, it will reports
a invalid opcode issue. Fix it. Only be compiled, not be tested.

Fixes: aeb20b6b3f4e ("drivers: net: xgene: fix: ifconfig up/down crash")
Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
---
 drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
index d6cfea65a714..390671640388 100644
--- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
+++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
@@ -1004,8 +1004,10 @@ static int xgene_enet_open(struct net_device *ndev)
 
 	xgene_enet_napi_enable(pdata);
 	ret = xgene_enet_register_irq(ndev);
-	if (ret)
+	if (ret) {
+		xgene_enet_napi_disable(pdata);
 		return ret;
+	}
 
 	if (ndev->phydev) {
 		phy_start(ndev->phydev);
-- 
2.17.1

Re: [PATCH] drivers: net: xgene: disable napi when register irq failed in xgene_enet_open()

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (master)
by Paolo Abeni <pabeni@redhat.com>:

On Mon, 7 Nov 2022 12:30:32 +0800 you wrote:
> When failed to register irq in xgene_enet_open() for opening device,
> napi isn't disabled. When open xgene device next time, it will reports
> a invalid opcode issue. Fix it. Only be compiled, not be tested.
> 
> Fixes: aeb20b6b3f4e ("drivers: net: xgene: fix: ifconfig up/down crash")
> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
> 
> [...]

Here is the summary with links:
  - drivers: net: xgene: disable napi when register irq failed in xgene_enet_open()
    https://git.kernel.org/netdev/net/c/ce9e57feeed8

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html