[PATCH net v2] net: cxgb3_main: disable napi when bind qsets failed in cxgb_up()

[PATCH net v2] net: cxgb3_main: disable napi when bind qsets failed in cxgb_up()

[Zhengchao Shao]

When failed to bind qsets in cxgb_up() for opening device, napi isn't
disabled. When open cxgb3 device next time, it will trigger a BUG_ON()
in napi_enable(). Compile tested only.

Fixes: 48c4b6dbb7e2 ("cxgb3 - fix port up/down error path")
Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
---
v2: modify the description and fixes tag
---
 drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c
index a52e6b6e2876..9b84c8d8d309 100644
--- a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c
+++ b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c
@@ -1301,6 +1301,7 @@ static int cxgb_up(struct adapter *adap)
 		if (ret < 0) {
 			CH_ERR(adap, "failed to bind qsets, err %d\n", ret);
 			t3_intr_disable(adap);
+			quiesce_rx(adap);
 			free_irq_resources(adap);
 			err = ret;
 			goto out;
-- 
2.17.1

Re: [PATCH net v2] net: cxgb3_main: disable napi when bind qsets failed in cxgb_up()

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 9 Nov 2022 10:14:51 +0800 you wrote:
> When failed to bind qsets in cxgb_up() for opening device, napi isn't
> disabled. When open cxgb3 device next time, it will trigger a BUG_ON()
> in napi_enable(). Compile tested only.
> 
> Fixes: 48c4b6dbb7e2 ("cxgb3 - fix port up/down error path")
> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
> 
> [...]

Here is the summary with links:
  - [net,v2] net: cxgb3_main: disable napi when bind qsets failed in cxgb_up()
    https://git.kernel.org/netdev/net/c/d75aed1428da

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html