* [PATCH net-next] net: libwx: Fix dead code for duplicate check
@ 2022-11-16 1:58 Jiawen Wu
2022-11-17 9:33 ` Leon Romanovsky
2022-11-18 11:00 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Jiawen Wu @ 2022-11-16 1:58 UTC (permalink / raw)
To: netdev, mengyuanlou; +Cc: Jiawen Wu
Fix duplicate check on polling timeout.
Fixes: 1efa9bfe58c5 ("net: libwx: Implement interaction with firmware")
Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
---
drivers/net/ethernet/wangxun/libwx/wx_hw.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/wangxun/libwx/wx_hw.c b/drivers/net/ethernet/wangxun/libwx/wx_hw.c
index 1eb7388f1dd5..c57dc3238b3f 100644
--- a/drivers/net/ethernet/wangxun/libwx/wx_hw.c
+++ b/drivers/net/ethernet/wangxun/libwx/wx_hw.c
@@ -203,8 +203,6 @@ int wx_host_interface_command(struct wx_hw *wxhw, u32 *buffer,
status = read_poll_timeout(rd32, hicr, hicr & WX_MNG_MBOX_CTL_FWRDY, 1000,
timeout * 1000, false, wxhw, WX_MNG_MBOX_CTL);
- if (status)
- goto rel_out;
/* Check command completion */
if (status) {
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: libwx: Fix dead code for duplicate check
2022-11-16 1:58 [PATCH net-next] net: libwx: Fix dead code for duplicate check Jiawen Wu
@ 2022-11-17 9:33 ` Leon Romanovsky
2022-11-18 11:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Leon Romanovsky @ 2022-11-17 9:33 UTC (permalink / raw)
To: Jiawen Wu; +Cc: netdev, mengyuanlou
On Wed, Nov 16, 2022 at 09:58:35AM +0800, Jiawen Wu wrote:
> Fix duplicate check on polling timeout.
>
> Fixes: 1efa9bfe58c5 ("net: libwx: Implement interaction with firmware")
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
> ---
> drivers/net/ethernet/wangxun/libwx/wx_hw.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/wangxun/libwx/wx_hw.c b/drivers/net/ethernet/wangxun/libwx/wx_hw.c
> index 1eb7388f1dd5..c57dc3238b3f 100644
> --- a/drivers/net/ethernet/wangxun/libwx/wx_hw.c
> +++ b/drivers/net/ethernet/wangxun/libwx/wx_hw.c
> @@ -203,8 +203,6 @@ int wx_host_interface_command(struct wx_hw *wxhw, u32 *buffer,
>
> status = read_poll_timeout(rd32, hicr, hicr & WX_MNG_MBOX_CTL_FWRDY, 1000,
> timeout * 1000, false, wxhw, WX_MNG_MBOX_CTL);
> - if (status)
> - goto rel_out;
BTW, this driver should use readx_poll_timeout() instead of read_poll_timeout(...).
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: libwx: Fix dead code for duplicate check
2022-11-16 1:58 [PATCH net-next] net: libwx: Fix dead code for duplicate check Jiawen Wu
2022-11-17 9:33 ` Leon Romanovsky
@ 2022-11-18 11:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-11-18 11:00 UTC (permalink / raw)
To: Jiawen Wu; +Cc: netdev, mengyuanlou
Hello:
This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:
On Wed, 16 Nov 2022 09:58:35 +0800 you wrote:
> Fix duplicate check on polling timeout.
>
> Fixes: 1efa9bfe58c5 ("net: libwx: Implement interaction with firmware")
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
> ---
> drivers/net/ethernet/wangxun/libwx/wx_hw.c | 2 --
> 1 file changed, 2 deletions(-)
Here is the summary with links:
- [net-next] net: libwx: Fix dead code for duplicate check
https://git.kernel.org/netdev/net-next/c/0b6ffefbb018
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-18 11:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-16 1:58 [PATCH net-next] net: libwx: Fix dead code for duplicate check Jiawen Wu
2022-11-17 9:33 ` Leon Romanovsky
2022-11-18 11:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).