netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 net-next] net: ethernet: renesas: rswitch: Fix MAC address info
@ 2022-11-18  0:27 Yoshihiro Shimoda
  2022-11-21 13:00 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Yoshihiro Shimoda @ 2022-11-18  0:27 UTC (permalink / raw)
  To: davem, edumazet, kuba, pabeni
  Cc: netdev, linux-renesas-soc, Yoshihiro Shimoda, Dan Carpenter,
	Geert Uytterhoeven, Saeed Mahameed

Smatch detected the following warning.

    drivers/net/ethernet/renesas/rswitch.c:1717 rswitch_init() warn:
    '%pM' cannot be followed by 'n'

The 'n' should be '\n'.

Reported-by: Dan Carpenter <error27@gmail.com>
Suggested-by: Geert Uytterhoeven <geert+renesas@glider.be>
Fixes: 3590918b5d07 ("net: ethernet: renesas: Add support for "Ethernet Switch"")
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Reviewed-by: Saeed Mahameed <saeed@kernel.org>
---
Changes from v1:
 https://lore.kernel.org/all/20221115235519.679115-1-yoshihiro.shimoda.uh@renesas.com/
 - Add Reviewed-by tag.

 drivers/net/ethernet/renesas/rswitch.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/renesas/rswitch.c b/drivers/net/ethernet/renesas/rswitch.c
index f3d27aef1286..51ce5c26631b 100644
--- a/drivers/net/ethernet/renesas/rswitch.c
+++ b/drivers/net/ethernet/renesas/rswitch.c
@@ -1714,7 +1714,7 @@ static int rswitch_init(struct rswitch_private *priv)
 	}
 
 	for (i = 0; i < RSWITCH_NUM_PORTS; i++)
-		netdev_info(priv->rdev[i]->ndev, "MAC address %pMn",
+		netdev_info(priv->rdev[i]->ndev, "MAC address %pM\n",
 			    priv->rdev[i]->ndev->dev_addr);
 
 	return 0;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2 net-next] net: ethernet: renesas: rswitch: Fix MAC address info
  2022-11-18  0:27 [PATCH v2 net-next] net: ethernet: renesas: rswitch: Fix MAC address info Yoshihiro Shimoda
@ 2022-11-21 13:00 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-11-21 13:00 UTC (permalink / raw)
  To: Yoshihiro Shimoda
  Cc: davem, edumazet, kuba, pabeni, netdev, linux-renesas-soc, error27,
	geert+renesas, saeed

Hello:

This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:

On Fri, 18 Nov 2022 09:27:24 +0900 you wrote:
> Smatch detected the following warning.
> 
>     drivers/net/ethernet/renesas/rswitch.c:1717 rswitch_init() warn:
>     '%pM' cannot be followed by 'n'
> 
> The 'n' should be '\n'.
> 
> [...]

Here is the summary with links:
  - [v2,net-next] net: ethernet: renesas: rswitch: Fix MAC address info
    https://git.kernel.org/netdev/net-next/c/1cb507263290

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-11-21 13:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-18  0:27 [PATCH v2 net-next] net: ethernet: renesas: rswitch: Fix MAC address info Yoshihiro Shimoda
2022-11-21 13:00 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).