From: patchwork-bot+netdevbpf@kernel.org
To: Kuniyuki Iwashima <kuniyu@amazon.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, dsahern@kernel.org, yoshfuji@linux-ipv6.org,
cpaasch@apple.com, fw@strlen.de, peter.krystad@linux.intel.com,
kuni1840@gmail.com, netdev@vger.kernel.org,
mptcp@lists.linux.dev
Subject: Re: [PATCH v2 net-next] net: Return errno in sk->sk_prot->get_port().
Date: Mon, 21 Nov 2022 13:10:16 +0000 [thread overview]
Message-ID: <166903621671.4573.8029560604179811568.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20221118182506.6226-1-kuniyu@amazon.com>
Hello:
This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:
On Fri, 18 Nov 2022 10:25:06 -0800 you wrote:
> We assume the correct errno is -EADDRINUSE when sk->sk_prot->get_port()
> fails, so some ->get_port() functions return just 1 on failure and the
> callers return -EADDRINUSE instead.
>
> However, mptcp_get_port() can return -EINVAL. Let's not ignore the error.
>
> Note the only exception is inet_autobind(), all of whose callers return
> -EAGAIN instead.
>
> [...]
Here is the summary with links:
- [v2,net-next] net: Return errno in sk->sk_prot->get_port().
https://git.kernel.org/netdev/net-next/c/7a7160edf1bf
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2022-11-21 13:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 18:25 [PATCH v2 net-next] net: Return errno in sk->sk_prot->get_port() Kuniyuki Iwashima
2022-11-21 13:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166903621671.4573.8029560604179811568.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=cpaasch@apple.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=kuniyu@amazon.com \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peter.krystad@linux.intel.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).