* [PATCH net] net: marvell: prestera: add missing unregister_netdev() in prestera_port_create()
@ 2022-11-22 11:10 Zhang Changzhong
2022-11-22 12:27 ` Maciej Fijalkowski
2022-11-24 4:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Zhang Changzhong @ 2022-11-22 11:10 UTC (permalink / raw)
To: Taras Chornyi, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Oleksandr Mazur, Yevhen Orlov
Cc: Zhang Changzhong, netdev, linux-kernel
If prestera_port_sfp_bind() fails, unregister_netdev() should be called
in error handling path.
Compile tested only.
Fixes: 52323ef75414 ("net: marvell: prestera: add phylink support")
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
---
drivers/net/ethernet/marvell/prestera/prestera_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/marvell/prestera/prestera_main.c b/drivers/net/ethernet/marvell/prestera/prestera_main.c
index 24f9d60..47796e4 100644
--- a/drivers/net/ethernet/marvell/prestera/prestera_main.c
+++ b/drivers/net/ethernet/marvell/prestera/prestera_main.c
@@ -746,6 +746,7 @@ static int prestera_port_create(struct prestera_switch *sw, u32 id)
return 0;
err_sfp_bind:
+ unregister_netdev(dev);
err_register_netdev:
prestera_port_list_del(port);
err_port_init:
--
2.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net] net: marvell: prestera: add missing unregister_netdev() in prestera_port_create()
2022-11-22 11:10 [PATCH net] net: marvell: prestera: add missing unregister_netdev() in prestera_port_create() Zhang Changzhong
@ 2022-11-22 12:27 ` Maciej Fijalkowski
2022-11-24 4:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Maciej Fijalkowski @ 2022-11-22 12:27 UTC (permalink / raw)
To: Zhang Changzhong
Cc: Taras Chornyi, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Oleksandr Mazur, Yevhen Orlov, netdev, linux-kernel
On Tue, Nov 22, 2022 at 07:10:31PM +0800, Zhang Changzhong wrote:
> If prestera_port_sfp_bind() fails, unregister_netdev() should be called
> in error handling path.
>
> Compile tested only.
>
> Fixes: 52323ef75414 ("net: marvell: prestera: add phylink support")
> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Makes sense and fixes commit is correct.
Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> ---
> drivers/net/ethernet/marvell/prestera/prestera_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/marvell/prestera/prestera_main.c b/drivers/net/ethernet/marvell/prestera/prestera_main.c
> index 24f9d60..47796e4 100644
> --- a/drivers/net/ethernet/marvell/prestera/prestera_main.c
> +++ b/drivers/net/ethernet/marvell/prestera/prestera_main.c
> @@ -746,6 +746,7 @@ static int prestera_port_create(struct prestera_switch *sw, u32 id)
> return 0;
>
> err_sfp_bind:
> + unregister_netdev(dev);
> err_register_netdev:
> prestera_port_list_del(port);
> err_port_init:
> --
> 2.9.5
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net] net: marvell: prestera: add missing unregister_netdev() in prestera_port_create()
2022-11-22 11:10 [PATCH net] net: marvell: prestera: add missing unregister_netdev() in prestera_port_create() Zhang Changzhong
2022-11-22 12:27 ` Maciej Fijalkowski
@ 2022-11-24 4:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-11-24 4:20 UTC (permalink / raw)
To: Zhang Changzhong
Cc: tchornyi, davem, edumazet, kuba, pabeni, oleksandr.mazur,
yevhen.orlov, netdev, linux-kernel
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 22 Nov 2022 19:10:31 +0800 you wrote:
> If prestera_port_sfp_bind() fails, unregister_netdev() should be called
> in error handling path.
>
> Compile tested only.
>
> Fixes: 52323ef75414 ("net: marvell: prestera: add phylink support")
> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
>
> [...]
Here is the summary with links:
- [net] net: marvell: prestera: add missing unregister_netdev() in prestera_port_create()
https://git.kernel.org/netdev/net/c/9a234a2a085a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-24 4:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-22 11:10 [PATCH net] net: marvell: prestera: add missing unregister_netdev() in prestera_port_create() Zhang Changzhong
2022-11-22 12:27 ` Maciej Fijalkowski
2022-11-24 4:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).