From: Wang Yufen <wangyufen@huawei.com>
To: <aspriel@gmail.com>, <franky.lin@broadcom.com>,
<hante.meuleman@broadcom.com>, <kvalo@kernel.org>,
<davem@davemloft.net>
Cc: <linux-wireless@vger.kernel.org>,
<brcm80211-dev-list.pdl@broadcom.com>,
<SHA-cyfmac-dev-list@infineon.com>, <netdev@vger.kernel.org>,
<arend@broadcom.com>, Wang Yufen <wangyufen@huawei.com>
Subject: [PATCH] wifi: brcmfmac: Fix error return code in brcmf_sdio_download_firmware()
Date: Tue, 29 Nov 2022 18:07:38 +0800 [thread overview]
Message-ID: <1669716458-15327-1-git-send-email-wangyufen@huawei.com> (raw)
Fix to return a negative error code -EINVAL instead of 0.
Compile tested only.
Fixes: d380ebc9b6fb ("brcmfmac: rename chip download functions")
Signed-off-by: Wang Yufen <wangyufen@huawei.com>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
index 465d95d..329ec8ac 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
@@ -3414,6 +3414,7 @@ static int brcmf_sdio_download_firmware(struct brcmf_sdio *bus,
/* Take arm out of reset */
if (!brcmf_chip_set_active(bus->ci, rstvec)) {
brcmf_err("error getting out of ARM core reset\n");
+ bcmerror = -EINVAL;
goto err;
}
--
1.8.3.1
next reply other threads:[~2022-11-29 9:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 10:07 Wang Yufen [this message]
2022-11-29 17:41 ` [PATCH] wifi: brcmfmac: Fix error return code in brcmf_sdio_download_firmware() Franky Lin
2022-11-30 2:00 ` wangyufen
2022-11-30 11:19 ` Arend van Spriel
2022-12-01 3:01 ` wangyufen
2022-12-01 6:18 ` Arend Van Spriel
2022-12-01 11:16 ` Kalle Valo
2022-12-02 4:59 ` wangyufen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1669716458-15327-1-git-send-email-wangyufen@huawei.com \
--to=wangyufen@huawei.com \
--cc=SHA-cyfmac-dev-list@infineon.com \
--cc=arend@broadcom.com \
--cc=aspriel@gmail.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=davem@davemloft.net \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).