* [PATCH iproute2 1/1] tc: ct: Fix invalid pointer dereference
@ 2022-12-07 8:22 Roi Dayan
2022-12-07 13:59 ` Jiri Pirko
2022-12-07 17:00 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Roi Dayan @ 2022-12-07 8:22 UTC (permalink / raw)
To: netdev; +Cc: Roi Dayan, Paul Blakey, Stephen Hemminger, David Ahern
Using macro NEXT_ARG_FWD does not validate argc.
Use macro NEXT_ARG which validates argc while parsing args
in the same loop iteration.
Fixes: c8a494314c40 ("tc: Introduce tc ct action")
Signed-off-by: Roi Dayan <roid@nvidia.com>
Reviewed-by: Paul Blakey <paulb@nvidia.com>
---
tc/m_ct.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tc/m_ct.c b/tc/m_ct.c
index a02bf0cc1655..54d64867abcb 100644
--- a/tc/m_ct.c
+++ b/tc/m_ct.c
@@ -243,7 +243,7 @@ parse_ct(struct action_util *a, int *argc_p, char ***argv_p, int tca_id,
return -1;
}
- NEXT_ARG_FWD();
+ NEXT_ARG();
if (matches(*argv, "port") != 0)
continue;
--
2.38.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH iproute2 1/1] tc: ct: Fix invalid pointer dereference
2022-12-07 8:22 [PATCH iproute2 1/1] tc: ct: Fix invalid pointer dereference Roi Dayan
@ 2022-12-07 13:59 ` Jiri Pirko
2022-12-07 17:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Pirko @ 2022-12-07 13:59 UTC (permalink / raw)
To: Roi Dayan; +Cc: netdev, Paul Blakey, Stephen Hemminger, David Ahern
Wed, Dec 07, 2022 at 09:22:13AM CET, roid@nvidia.com wrote:
>Using macro NEXT_ARG_FWD does not validate argc.
>Use macro NEXT_ARG which validates argc while parsing args
>in the same loop iteration.
>
>Fixes: c8a494314c40 ("tc: Introduce tc ct action")
>Signed-off-by: Roi Dayan <roid@nvidia.com>
>Reviewed-by: Paul Blakey <paulb@nvidia.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH iproute2 1/1] tc: ct: Fix invalid pointer dereference
2022-12-07 8:22 [PATCH iproute2 1/1] tc: ct: Fix invalid pointer dereference Roi Dayan
2022-12-07 13:59 ` Jiri Pirko
@ 2022-12-07 17:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-12-07 17:00 UTC (permalink / raw)
To: Roi Dayan; +Cc: netdev, paulb, stephen, dsahern
Hello:
This patch was applied to iproute2/iproute2.git (main)
by Stephen Hemminger <stephen@networkplumber.org>:
On Wed, 7 Dec 2022 10:22:13 +0200 you wrote:
> Using macro NEXT_ARG_FWD does not validate argc.
> Use macro NEXT_ARG which validates argc while parsing args
> in the same loop iteration.
>
> Fixes: c8a494314c40 ("tc: Introduce tc ct action")
> Signed-off-by: Roi Dayan <roid@nvidia.com>
> Reviewed-by: Paul Blakey <paulb@nvidia.com>
>
> [...]
Here is the summary with links:
- [iproute2,1/1] tc: ct: Fix invalid pointer dereference
https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=4de59102f49f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-07 17:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-07 8:22 [PATCH iproute2 1/1] tc: ct: Fix invalid pointer dereference Roi Dayan
2022-12-07 13:59 ` Jiri Pirko
2022-12-07 17:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).