From: patchwork-bot+netdevbpf@kernel.org
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: davem@davemloft.net, kuba@kernel.org, edumazet@google.com,
pabeni@redhat.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
netdev@vger.kernel.org, zengyhkyle@gmail.com
Subject: Re: [PATCH net 0/2] dont intepret cls results when asked to drop
Date: Mon, 02 Jan 2023 13:40:16 +0000 [thread overview]
Message-ID: <167266681614.16415.10787367511404690308.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230101215744.709178-1-jhs@mojatatu.com>
Hello:
This series was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Sun, 1 Jan 2023 16:57:42 -0500 you wrote:
> It is possible that an error in processing may occur in tcf_classify() which
> will result in res.classid being some garbage value. Example of such a code path
> is when the classifier goes into a loop due to bad policy. See patch 1/2
> for a sample splat.
> While the core code reacts correctly and asks the caller to drop the packet
> (by returning TC_ACT_SHOT) some callers first intepret the res.class as
> a pointer to memory and end up dropping the packet only after some activity with
> the pointer. There is likelihood of this resulting in an exploit. So lets fix
> all the known qdiscs that behave this way.
>
> [...]
Here is the summary with links:
- [net,1/2] net: sched: atm: dont intepret cls results when asked to drop
https://git.kernel.org/netdev/net/c/a2965c7be052
- [net,2/2] net: sched: cbq: dont intepret cls results when asked to drop
(no matching commit)
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-01-02 13:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-01 21:57 [PATCH net 0/2] dont intepret cls results when asked to drop Jamal Hadi Salim
2023-01-01 21:57 ` [PATCH net 1/2] net: sched: atm: " Jamal Hadi Salim
2023-01-01 21:57 ` [PATCH net 2/2] net: sched: cbq: " Jamal Hadi Salim
2023-01-02 13:40 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167266681614.16415.10787367511404690308.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xiyou.wangcong@gmail.com \
--cc=zengyhkyle@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).