netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH iproute] add space after keyword
@ 2023-01-16 17:20 Stephen Hemminger
  2023-01-16 18:10 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2023-01-16 17:20 UTC (permalink / raw)
  To: netdev; +Cc: Stephen Hemminger

The style standard is to use space after keywords.
Example:
	if (expr)
verus
	if(expr)

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 dcb/dcb_app.c     | 2 +-
 devlink/devlink.c | 2 +-
 ip/iprule.c       | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/dcb/dcb_app.c b/dcb/dcb_app.c
index b9ac8f4bce59..eeb78e70f63f 100644
--- a/dcb/dcb_app.c
+++ b/dcb/dcb_app.c
@@ -264,7 +264,7 @@ static int dcb_app_parse_pcp(__u32 *key, const char *arg)
 {
 	int i;
 
-	for(i = 0; i < ARRAY_SIZE(pcp_names); i++) {
+	for (i = 0; i < ARRAY_SIZE(pcp_names); i++) {
 		if (pcp_names[i] && strcmp(arg, pcp_names[i]) == 0) {
 			*key = i;
 			return 0;
diff --git a/devlink/devlink.c b/devlink/devlink.c
index 931a768a41d1..795f8318c0c4 100644
--- a/devlink/devlink.c
+++ b/devlink/devlink.c
@@ -1963,7 +1963,7 @@ static int dl_argv_parse(struct dl *dl, uint64_t o_required,
 
 			dl_arg_inc(dl);
 			err = dl_argv_str(dl, &sectionstr);
-			if(err)
+			if (err)
 				return err;
 			err = flash_overwrite_section_get(sectionstr,
 							  &opts->overwrite_mask);
diff --git a/ip/iprule.c b/ip/iprule.c
index 654ffffe3cc0..458607efd93f 100644
--- a/ip/iprule.c
+++ b/ip/iprule.c
@@ -695,7 +695,7 @@ static int iprule_list_flush_or_save(int argc, char **argv, int action)
 			else if (ret != 2)
 				invarg("invalid dport range\n", *argv);
 			filter.dport = r;
-		} else{
+		} else {
 			if (matches(*argv, "dst") == 0 ||
 			    matches(*argv, "to") == 0) {
 				NEXT_ARG();
-- 
2.39.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH iproute] add space after keyword
  2023-01-16 17:20 [PATCH iproute] add space after keyword Stephen Hemminger
@ 2023-01-16 18:10 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-01-16 18:10 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: netdev

Hello:

This patch was applied to iproute2/iproute2.git (main)
by Stephen Hemminger <stephen@networkplumber.org>:

On Mon, 16 Jan 2023 09:20:46 -0800 you wrote:
> The style standard is to use space after keywords.
> Example:
> 	if (expr)
> verus
> 	if(expr)
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> 
> [...]

Here is the summary with links:
  - [iproute] add space after keyword
    https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=46686c563b91

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-01-16 18:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-16 17:20 [PATCH iproute] add space after keyword Stephen Hemminger
2023-01-16 18:10 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).