From: patchwork-bot+netdevbpf@kernel.org
To: Jesper Dangaard Brouer <brouer@redhat.com>
Cc: netdev@vger.kernel.org, kuba@kernel.org, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com,
syzbot+c8a2e66e37eee553c4fd@syzkaller.appspotmail.com
Subject: Re: [PATCH net-next V2] net: fix kfree_skb_list use of skb_mark_not_on_list
Date: Tue, 24 Jan 2023 05:50:18 +0000 [thread overview]
Message-ID: <167453941816.4419.3173739226608329808.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <167421088417.1125894.9761158218878962159.stgit@firesoul>
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 20 Jan 2023 11:34:44 +0100 you wrote:
> A bug was introduced by commit eedade12f4cb ("net: kfree_skb_list use
> kmem_cache_free_bulk"). It unconditionally unlinked the SKB list via
> invoking skb_mark_not_on_list().
>
> In this patch we choose to remove the skb_mark_not_on_list() call as it
> isn't necessary. It would be possible and correct to call
> skb_mark_not_on_list() only when __kfree_skb_reason() returns true,
> meaning the SKB is ready to be free'ed, as it calls/check skb_unref().
>
> [...]
Here is the summary with links:
- [net-next,V2] net: fix kfree_skb_list use of skb_mark_not_on_list
https://git.kernel.org/netdev/net-next/c/f72ff8b81ebc
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-01-24 5:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 10:34 [PATCH net-next V2] net: fix kfree_skb_list use of skb_mark_not_on_list Jesper Dangaard Brouer
2023-01-20 12:40 ` Eric Dumazet
2023-01-24 5:50 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167453941816.4419.3173739226608329808.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+c8a2e66e37eee553c4fd@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox