* [PATCH net-next] net: mscc: ocelot: fix incorrect verify_enabled reporting in ethtool get_mm()
@ 2023-01-23 18:45 Vladimir Oltean
2023-01-25 2:40 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Vladimir Oltean @ 2023-01-23 18:45 UTC (permalink / raw)
To: netdev
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Claudiu Manoil, Xiaoliang Yang, UNGLinuxDriver, Alexandre Belloni,
Andrew Lunn, Florian Fainelli
We don't read the verify_enabled variable from hardware in the MAC Merge
layer state GET operation, instead we always leave it set to "false".
The user may think something is wrong if they set verify_enabled to
true, then read it back and see it's still false, even though the
configuration took place.
Fixes: 6505b6805655 ("net: mscc: ocelot: add MAC Merge layer support for VSC9959")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
drivers/net/ethernet/mscc/ocelot_mm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/mscc/ocelot_mm.c b/drivers/net/ethernet/mscc/ocelot_mm.c
index 08820f2341a1..0a8f21ae23f0 100644
--- a/drivers/net/ethernet/mscc/ocelot_mm.c
+++ b/drivers/net/ethernet/mscc/ocelot_mm.c
@@ -165,6 +165,7 @@ int ocelot_port_get_mm(struct ocelot *ocelot, int port,
state->tx_enabled = !!(val & DEV_MM_CONFIG_ENABLE_CONFIG_MM_TX_ENA);
val = ocelot_port_readl(ocelot_port, DEV_MM_VERIF_CONFIG);
+ state->verify_enabled = !(val & DEV_MM_CONFIG_VERIF_CONFIG_PRM_VERIFY_DIS);
state->verify_time = DEV_MM_CONFIG_VERIF_CONFIG_PRM_VERIFY_TIME_X(val);
state->max_verify_time = 128;
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net-next] net: mscc: ocelot: fix incorrect verify_enabled reporting in ethtool get_mm()
2023-01-23 18:45 [PATCH net-next] net: mscc: ocelot: fix incorrect verify_enabled reporting in ethtool get_mm() Vladimir Oltean
@ 2023-01-25 2:40 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-01-25 2:40 UTC (permalink / raw)
To: Vladimir Oltean
Cc: netdev, davem, edumazet, kuba, pabeni, claudiu.manoil,
xiaoliang.yang_1, UNGLinuxDriver, alexandre.belloni, andrew,
f.fainelli
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 23 Jan 2023 20:45:38 +0200 you wrote:
> We don't read the verify_enabled variable from hardware in the MAC Merge
> layer state GET operation, instead we always leave it set to "false".
> The user may think something is wrong if they set verify_enabled to
> true, then read it back and see it's still false, even though the
> configuration took place.
>
> Fixes: 6505b6805655 ("net: mscc: ocelot: add MAC Merge layer support for VSC9959")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
>
> [...]
Here is the summary with links:
- [net-next] net: mscc: ocelot: fix incorrect verify_enabled reporting in ethtool get_mm()
https://git.kernel.org/netdev/net-next/c/28113cfada8b
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-25 2:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-23 18:45 [PATCH net-next] net: mscc: ocelot: fix incorrect verify_enabled reporting in ethtool get_mm() Vladimir Oltean
2023-01-25 2:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).