From: Moshe Shemesh <moshe@nvidia.com>
To: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Jiri Pirko <jiri@nvidia.com>,
<netdev@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>, Moshe Shemesh <moshe@nvidia.com>
Subject: [PATCH net-next 6/7] devlink: Move devlink_info_req struct to be local
Date: Thu, 2 Feb 2023 16:47:05 +0200 [thread overview]
Message-ID: <1675349226-284034-7-git-send-email-moshe@nvidia.com> (raw)
In-Reply-To: <1675349226-284034-1-git-send-email-moshe@nvidia.com>
As all users of the struct devlink_info_req are already in dev.c, move
this struct from devl_internal.c to be local in dev.c.
Signed-off-by: Moshe Shemesh <moshe@nvidia.com>
---
net/devlink/dev.c | 8 ++++++++
net/devlink/devl_internal.h | 9 ---------
2 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/net/devlink/dev.c b/net/devlink/dev.c
index 83760e6c8c19..dcf0935462e8 100644
--- a/net/devlink/dev.c
+++ b/net/devlink/dev.c
@@ -8,6 +8,14 @@
#include <net/sock.h>
#include "devl_internal.h"
+struct devlink_info_req {
+ struct sk_buff *msg;
+ void (*version_cb)(const char *version_name,
+ enum devlink_info_version_type version_type,
+ void *version_cb_priv);
+ void *version_cb_priv;
+};
+
struct devlink_reload_combination {
enum devlink_reload_action action;
enum devlink_reload_limit limit;
diff --git a/net/devlink/devl_internal.h b/net/devlink/devl_internal.h
index 5fbd757b2f56..a5c29ad20564 100644
--- a/net/devlink/devl_internal.h
+++ b/net/devlink/devl_internal.h
@@ -189,15 +189,6 @@ static inline bool devlink_reload_supported(const struct devlink_ops *ops)
return ops->reload_down && ops->reload_up;
}
-/* Dev info */
-struct devlink_info_req {
- struct sk_buff *msg;
- void (*version_cb)(const char *version_name,
- enum devlink_info_version_type version_type,
- void *version_cb_priv);
- void *version_cb_priv;
-};
-
/* Resources */
struct devlink_resource;
int devlink_resources_validate(struct devlink *devlink,
--
2.27.0
next prev parent reply other threads:[~2023-02-02 14:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-02 14:46 [PATCH net-next 0/7] devlink: Move devlink dev code to a separate file Moshe Shemesh
2023-02-02 14:47 ` [PATCH net-next 1/7] devlink: Split out dev get and dump code Moshe Shemesh
2023-02-02 14:47 ` [PATCH net-next 2/7] devlink: Move devlink dev reload code to dev Moshe Shemesh
2023-02-02 14:47 ` [PATCH net-next 3/7] devlink: Move devlink dev eswitch " Moshe Shemesh
2023-02-02 14:47 ` [PATCH net-next 4/7] devlink: Move devlink dev info " Moshe Shemesh
2023-02-02 14:47 ` [PATCH net-next 5/7] devlink: Move devlink dev flash " Moshe Shemesh
2023-02-02 14:47 ` Moshe Shemesh [this message]
2023-02-02 14:47 ` [PATCH net-next 7/7] devlink: Move devlink dev selftest " Moshe Shemesh
2023-02-02 18:17 ` Jakub Kicinski
2023-02-02 19:33 ` Moshe Shemesh
2023-02-02 19:46 ` Jakub Kicinski
2023-02-03 8:02 ` Jiri Pirko
2023-02-02 15:44 ` [PATCH net-next 0/7] devlink: Move devlink dev code to a separate file Jiri Pirko
2023-02-04 3:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1675349226-284034-7-git-send-email-moshe@nvidia.com \
--to=moshe@nvidia.com \
--cc=davem@davemloft.net \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).