From: patchwork-bot+netdevbpf@kernel.org
To: Fedor Pchelkin <pchelkin@ispras.ru>
Cc: pshelar@ovn.org, simon.horman@corigine.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
echaudro@redhat.com, netdev@vger.kernel.org, dev@openvswitch.org,
linux-kernel@vger.kernel.org, khoroshilov@ispras.ru,
lvc-project@linuxtesting.org
Subject: Re: [PATCH v2] net: openvswitch: fix flow memory leak in ovs_flow_cmd_new
Date: Thu, 02 Feb 2023 19:40:18 +0000 [thread overview]
Message-ID: <167536681814.25016.4688800078010705767.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230201210218.361970-1-pchelkin@ispras.ru>
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 2 Feb 2023 00:02:18 +0300 you wrote:
> Syzkaller reports a memory leak of new_flow in ovs_flow_cmd_new() as it is
> not freed when an allocation of a key fails.
>
> BUG: memory leak
> unreferenced object 0xffff888116668000 (size 632):
> comm "syz-executor231", pid 1090, jiffies 4294844701 (age 18.871s)
> hex dump (first 32 bytes):
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> backtrace:
> [<00000000defa3494>] kmem_cache_zalloc include/linux/slab.h:654 [inline]
> [<00000000defa3494>] ovs_flow_alloc+0x19/0x180 net/openvswitch/flow_table.c:77
> [<00000000c67d8873>] ovs_flow_cmd_new+0x1de/0xd40 net/openvswitch/datapath.c:957
> [<0000000010a539a8>] genl_family_rcv_msg_doit+0x22d/0x330 net/netlink/genetlink.c:739
> [<00000000dff3302d>] genl_family_rcv_msg net/netlink/genetlink.c:783 [inline]
> [<00000000dff3302d>] genl_rcv_msg+0x328/0x590 net/netlink/genetlink.c:800
> [<000000000286dd87>] netlink_rcv_skb+0x153/0x430 net/netlink/af_netlink.c:2515
> [<0000000061fed410>] genl_rcv+0x24/0x40 net/netlink/genetlink.c:811
> [<000000009dc0f111>] netlink_unicast_kernel net/netlink/af_netlink.c:1313 [inline]
> [<000000009dc0f111>] netlink_unicast+0x545/0x7f0 net/netlink/af_netlink.c:1339
> [<000000004a5ee816>] netlink_sendmsg+0x8e7/0xde0 net/netlink/af_netlink.c:1934
> [<00000000482b476f>] sock_sendmsg_nosec net/socket.c:651 [inline]
> [<00000000482b476f>] sock_sendmsg+0x152/0x190 net/socket.c:671
> [<00000000698574ba>] ____sys_sendmsg+0x70a/0x870 net/socket.c:2356
> [<00000000d28d9e11>] ___sys_sendmsg+0xf3/0x170 net/socket.c:2410
> [<0000000083ba9120>] __sys_sendmsg+0xe5/0x1b0 net/socket.c:2439
> [<00000000c00628f8>] do_syscall_64+0x30/0x40 arch/x86/entry/common.c:46
> [<000000004abfdcf4>] entry_SYSCALL_64_after_hwframe+0x61/0xc6
>
> [...]
Here is the summary with links:
- [v2] net: openvswitch: fix flow memory leak in ovs_flow_cmd_new
https://git.kernel.org/netdev/net/c/0c598aed445e
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-02-02 19:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-31 19:19 [PATCH] net: openvswitch: fix flow memory leak in ovs_flow_cmd_new Fedor Pchelkin
2023-02-01 15:45 ` Simon Horman
2023-02-01 16:28 ` Fedor Pchelkin
2023-02-01 16:54 ` Simon Horman
2023-02-01 21:02 ` [PATCH v2] " Fedor Pchelkin
2023-02-02 8:11 ` Eelco Chaudron
2023-02-02 9:05 ` Simon Horman
2023-02-02 19:40 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167536681814.25016.4688800078010705767.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=echaudro@redhat.com \
--cc=edumazet@google.com \
--cc=khoroshilov@ispras.ru \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pchelkin@ispras.ru \
--cc=pshelar@ovn.org \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).