* [PATCH net] net: ethernet: mtk_eth_soc: fix wrong parameters order in __xdp_rxq_info_reg()
@ 2023-02-06 20:47 Tariq Toukan
2023-02-08 9:10 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Tariq Toukan @ 2023-02-06 20:47 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski, Felix Fietkau, Lorenzo Bianconi,
John Crispin, Sean Wang, Mark Lee
Cc: Eric Dumazet, Paolo Abeni, netdev, Saeed Mahameed, Gal Pressman,
Tariq Toukan
Parameters 'queue_index' and 'napi_id' are passed in a swapped order.
Fix it here.
Fixes: 23233e577ef9 ("net: ethernet: mtk_eth_soc: rely on page_pool for single page buffers")
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index d56eda6397a4..fa2fa170dcb9 100644
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -1570,8 +1570,8 @@ static struct page_pool *mtk_create_page_pool(struct mtk_eth *eth,
if (IS_ERR(pp))
return pp;
- err = __xdp_rxq_info_reg(xdp_q, ð->dummy_dev, eth->rx_napi.napi_id,
- id, PAGE_SIZE);
+ err = __xdp_rxq_info_reg(xdp_q, ð->dummy_dev, id,
+ eth->rx_napi.napi_id, PAGE_SIZE);
if (err < 0)
goto err_free_pp;
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] net: ethernet: mtk_eth_soc: fix wrong parameters order in __xdp_rxq_info_reg()
2023-02-06 20:47 [PATCH net] net: ethernet: mtk_eth_soc: fix wrong parameters order in __xdp_rxq_info_reg() Tariq Toukan
@ 2023-02-08 9:10 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-02-08 9:10 UTC (permalink / raw)
To: Tariq Toukan
Cc: davem, kuba, nbd, lorenzo, john, sean.wang, Mark-MC.Lee, edumazet,
pabeni, netdev, saeedm, gal
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Mon, 6 Feb 2023 22:47:03 +0200 you wrote:
> Parameters 'queue_index' and 'napi_id' are passed in a swapped order.
> Fix it here.
>
> Fixes: 23233e577ef9 ("net: ethernet: mtk_eth_soc: rely on page_pool for single page buffers")
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
> ---
> drivers/net/ethernet/mediatek/mtk_eth_soc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Here is the summary with links:
- [net] net: ethernet: mtk_eth_soc: fix wrong parameters order in __xdp_rxq_info_reg()
https://git.kernel.org/netdev/net/c/c966153d1202
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-08 9:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-06 20:47 [PATCH net] net: ethernet: mtk_eth_soc: fix wrong parameters order in __xdp_rxq_info_reg() Tariq Toukan
2023-02-08 9:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).