* [PATCH net-next] netlink-specs: add rx-push to ethtool family
@ 2023-02-14 4:32 Jakub Kicinski
2023-02-14 18:29 ` Shannon Nelson
2023-02-15 4:50 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Jakub Kicinski @ 2023-02-14 4:32 UTC (permalink / raw)
To: davem; +Cc: netdev, edumazet, pabeni, Jakub Kicinski, Shannon Nelson
Commit 5b4e9a7a71ab ("net: ethtool: extend ringparam set/get APIs for rx_push")
added a new attr for configuring rx-push, right after tx-push.
Add it to the spec, the ring param operation is covered by
the otherwise sparse ethtool spec.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
Cc: Shannon Nelson <shannon.nelson@amd.com>
---
Documentation/netlink/specs/ethtool.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml
index 82f4e6f8ddd3..08b776908d15 100644
--- a/Documentation/netlink/specs/ethtool.yaml
+++ b/Documentation/netlink/specs/ethtool.yaml
@@ -171,6 +171,9 @@ doc: Partial family for Ethtool Netlink.
-
name: tx-push
type: u8
+ -
+ name: rx-push
+ type: u8
-
name: mm-stat
@@ -320,6 +323,7 @@ doc: Partial family for Ethtool Netlink.
- tcp-data-split
- cqe-size
- tx-push
+ - rx-push
dump: *ring-get-op
-
name: rings-set
@@ -339,6 +343,7 @@ doc: Partial family for Ethtool Netlink.
- tcp-data-split
- cqe-size
- tx-push
+ - rx-push
-
name: rings-ntf
doc: Notification for change in ring params.
--
2.39.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] netlink-specs: add rx-push to ethtool family
2023-02-14 4:32 [PATCH net-next] netlink-specs: add rx-push to ethtool family Jakub Kicinski
@ 2023-02-14 18:29 ` Shannon Nelson
2023-02-15 4:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Shannon Nelson @ 2023-02-14 18:29 UTC (permalink / raw)
To: Jakub Kicinski, davem; +Cc: netdev, edumazet, pabeni
On 2/13/23 8:32 PM, Jakub Kicinski wrote:
> Commit 5b4e9a7a71ab ("net: ethtool: extend ringparam set/get APIs for rx_push")
> added a new attr for configuring rx-push, right after tx-push.
> Add it to the spec, the ring param operation is covered by
> the otherwise sparse ethtool spec.
Thanks for catching that
Reviewed-by: Shannon Nelson <shannon.nelson@amd.com>
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> Cc: Shannon Nelson <shannon.nelson@amd.com>
> ---
> Documentation/netlink/specs/ethtool.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml
> index 82f4e6f8ddd3..08b776908d15 100644
> --- a/Documentation/netlink/specs/ethtool.yaml
> +++ b/Documentation/netlink/specs/ethtool.yaml
> @@ -171,6 +171,9 @@ doc: Partial family for Ethtool Netlink.
> -
> name: tx-push
> type: u8
> + -
> + name: rx-push
> + type: u8
>
> -
> name: mm-stat
> @@ -320,6 +323,7 @@ doc: Partial family for Ethtool Netlink.
> - tcp-data-split
> - cqe-size
> - tx-push
> + - rx-push
> dump: *ring-get-op
> -
> name: rings-set
> @@ -339,6 +343,7 @@ doc: Partial family for Ethtool Netlink.
> - tcp-data-split
> - cqe-size
> - tx-push
> + - rx-push
> -
> name: rings-ntf
> doc: Notification for change in ring params.
> --
> 2.39.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] netlink-specs: add rx-push to ethtool family
2023-02-14 4:32 [PATCH net-next] netlink-specs: add rx-push to ethtool family Jakub Kicinski
2023-02-14 18:29 ` Shannon Nelson
@ 2023-02-15 4:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-02-15 4:50 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: davem, netdev, edumazet, pabeni, shannon.nelson
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 13 Feb 2023 20:32:46 -0800 you wrote:
> Commit 5b4e9a7a71ab ("net: ethtool: extend ringparam set/get APIs for rx_push")
> added a new attr for configuring rx-push, right after tx-push.
> Add it to the spec, the ring param operation is covered by
> the otherwise sparse ethtool spec.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
>
> [...]
Here is the summary with links:
- [net-next] netlink-specs: add rx-push to ethtool family
https://git.kernel.org/netdev/net-next/c/1ed32ad4a3cb
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-15 4:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-14 4:32 [PATCH net-next] netlink-specs: add rx-push to ethtool family Jakub Kicinski
2023-02-14 18:29 ` Shannon Nelson
2023-02-15 4:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).