From: patchwork-bot+netdevbpf@kernel.org
To: Dan Carpenter <error27@gmail.com>
Cc: Frank.Sae@motor-comm.com, andrew@lunn.ch, hkallweit1@gmail.com,
linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2 net-next] net: phy: motorcomm: uninitialized variables in yt8531_link_change_notify()
Date: Thu, 16 Feb 2023 05:30:19 +0000 [thread overview]
Message-ID: <167652541903.5481.7404304709458067270.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <Y+xd2yJet2ImHLoQ@kili>
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 15 Feb 2023 07:21:47 +0300 you wrote:
> These booleans are never set to false, but are just used without being
> initialized.
>
> Fixes: 4ac94f728a58 ("net: phy: Add driver for Motorcomm yt8531 gigabit ethernet phy")
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> v2: reverse Christmas tree. Also add "motorcomm" to the subject. It
> really feels like previous patches to this driver should have had
> motorcomm in the subject as well. It's a common anti-pattern to only
> put the subsystem name and not the driver name when adding a new file.
>
> [...]
Here is the summary with links:
- [v2,net-next] net: phy: motorcomm: uninitialized variables in yt8531_link_change_notify()
https://git.kernel.org/netdev/net-next/c/9753613f7399
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-02-16 5:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 4:21 [PATCH v2 net-next] net: phy: motorcomm: uninitialized variables in yt8531_link_change_notify() Dan Carpenter
2023-02-15 5:19 ` Frank Sae
2023-02-16 5:30 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167652541903.5481.7404304709458067270.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=Frank.Sae@motor-comm.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=error27@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).