netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH iproute2] tc: m_action: fix parsing of TCA_EXT_WARN_MSG
@ 2023-02-24 17:57 Pedro Tammela
  2023-02-24 18:20 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Pedro Tammela @ 2023-02-24 17:57 UTC (permalink / raw)
  To: netdev; +Cc: jhs, liuhangbin, Pedro Tammela

It should sit within the TCA_ACT_TAB hierarchy, otherwise the access to
tb is out of bounds:
./tc action ls action csum
total acts 1

        action order 0: csum (?empty) action pass
        index 1 ref 1 bind 0
        not_in_hw
Segmentation fault (core dumped)

Fixes: 60359956 ("tc: add new attr TCA_EXT_WARN_MSG")
Reviewed-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: Pedro Tammela <pctammela@mojatatu.com>
---
 tc/m_action.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tc/m_action.c b/tc/m_action.c
index 0400132c..6c91af2c 100644
--- a/tc/m_action.c
+++ b/tc/m_action.c
@@ -586,7 +586,7 @@ int print_action(struct nlmsghdr *n, void *arg)
 
 	open_json_object(NULL);
 	tc_dump_action(fp, tb[TCA_ACT_TAB], tot_acts ? *tot_acts:0, false);
-	print_ext_msg(tb);
+	print_ext_msg(&tb[TCA_ACT_TAB]);
 	close_json_object();
 
 	return 0;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH iproute2] tc: m_action: fix parsing of TCA_EXT_WARN_MSG
  2023-02-24 17:57 [PATCH iproute2] tc: m_action: fix parsing of TCA_EXT_WARN_MSG Pedro Tammela
@ 2023-02-24 18:20 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-02-24 18:20 UTC (permalink / raw)
  To: Pedro Tammela; +Cc: netdev, jhs, liuhangbin

Hello:

This patch was applied to iproute2/iproute2.git (main)
by Stephen Hemminger <stephen@networkplumber.org>:

On Fri, 24 Feb 2023 14:57:56 -0300 you wrote:
> It should sit within the TCA_ACT_TAB hierarchy, otherwise the access to
> tb is out of bounds:
> ./tc action ls action csum
> total acts 1
> 
>         action order 0: csum (?empty) action pass
>         index 1 ref 1 bind 0
>         not_in_hw
> Segmentation fault (core dumped)
> 
> [...]

Here is the summary with links:
  - [iproute2] tc: m_action: fix parsing of TCA_EXT_WARN_MSG
    https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=70b9ebae63ce

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-02-24 18:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-24 17:57 [PATCH iproute2] tc: m_action: fix parsing of TCA_EXT_WARN_MSG Pedro Tammela
2023-02-24 18:20 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).