[PATCH net v2] r8169: fix RTL8168H and RTL8107E rx crc error

[PATCH net v2] r8169: fix RTL8168H and RTL8107E rx crc error

[ChunHao Lin]

When link speed is 10 Mbps and temperature is under -20°C, RTL8168H and
RTL8107E may have rx crc error. Disable phy 10 Mbps pll off to fix this
issue.

Fixes: 6e1d0b898818 ("r8169:add support for RTL8168H and RTL8107E")
Signed-off-by: ChunHao Lin <hau@realtek.com>
---
V1 -> V2:
- add Fixes tag
- change title and description

 drivers/net/ethernet/realtek/r8169_phy_config.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/ethernet/realtek/r8169_phy_config.c b/drivers/net/ethernet/realtek/r8169_phy_config.c
index 930496cd34ed..b50f16786c24 100644
--- a/drivers/net/ethernet/realtek/r8169_phy_config.c
+++ b/drivers/net/ethernet/realtek/r8169_phy_config.c
@@ -826,6 +826,9 @@ static void rtl8168h_2_hw_phy_config(struct rtl8169_private *tp,
 	/* disable phy pfm mode */
 	phy_modify_paged(phydev, 0x0a44, 0x11, BIT(7), 0);
 
+	/* disable 10m pll off */
+	phy_modify_paged(phydev, 0x0a43, 0x10, BIT(0), 0);
+
 	rtl8168g_disable_aldps(phydev);
 	rtl8168g_config_eee_phy(phydev);
 }
-- 
2.37.2

Re: [PATCH net v2] r8169: fix RTL8168H and RTL8107E rx crc error

[Jakub Kicinski]

On Thu, 23 Mar 2023 22:33:09 +0800 ChunHao Lin wrote:
> When link speed is 10 Mbps and temperature is under -20°C, RTL8168H and
> RTL8107E may have rx crc error. Disable phy 10 Mbps pll off to fix this
> issue.
> 
> Fixes: 6e1d0b898818 ("r8169:add support for RTL8168H and RTL8107E")
> Signed-off-by: ChunHao Lin <hau@realtek.com>

Hi Heiner, looks good?

Re: [PATCH net v2] r8169: fix RTL8168H and RTL8107E rx crc error

[Heiner Kallweit]

On 23.03.2023 15:33, ChunHao Lin wrote:
> When link speed is 10 Mbps and temperature is under -20°C, RTL8168H and
> RTL8107E may have rx crc error. Disable phy 10 Mbps pll off to fix this
> issue.
> 
> Fixes: 6e1d0b898818 ("r8169:add support for RTL8168H and RTL8107E")
> Signed-off-by: ChunHao Lin <hau@realtek.com>
> ---
> V1 -> V2:
> - add Fixes tag
> - change title and description
> 
Reviewed-by: Heiner Kallweit <hkallweit1@gmail.com>

Re: [PATCH net v2] r8169: fix RTL8168H and RTL8107E rx crc error

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:

On Thu, 23 Mar 2023 22:33:09 +0800 you wrote:
> When link speed is 10 Mbps and temperature is under -20°C, RTL8168H and
> RTL8107E may have rx crc error. Disable phy 10 Mbps pll off to fix this
> issue.
> 
> Fixes: 6e1d0b898818 ("r8169:add support for RTL8168H and RTL8107E")
> Signed-off-by: ChunHao Lin <hau@realtek.com>
> 
> [...]

Here is the summary with links:
  - [net,v2] r8169: fix RTL8168H and RTL8107E rx crc error
    https://git.kernel.org/netdev/net/c/33189f0a94b9

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html