From: Johannes Berg <johannes@sipsolutions.net>
To: Ramon Fontes <ramonreisfontes@gmail.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org
Cc: kvalo@codeaurora.org, davem@davemloft.net
Subject: Re: [PATCH] mac80211_hwsim: enable 6GHz channels
Date: Wed, 22 Sep 2021 16:29:37 +0200 [thread overview]
Message-ID: <167f632eb19944b5711a584218e57b51da85df96.camel@sipsolutions.net> (raw)
In-Reply-To: <20210922142803.192601-1-ramonreisfontes@gmail.com>
On Wed, 2021-09-22 at 11:28 -0300, Ramon Fontes wrote:
> This adds 6 GHz capabilities and reject HT/VHT
>
It'd be nice to add a version to the subject, with -vN on the git-send-
email commandline :)
> + .he_6ghz_capa = {
> + .capa = IEEE80211_HE_6GHZ_CAP_MIN_MPDU_START |
> + IEEE80211_HE_6GHZ_CAP_MAX_AMPDU_LEN_EXP |
> + IEEE80211_HE_6GHZ_CAP_MAX_MPDU_LEN |
> + cpu_to_le16(IEEE80211_HE_6GHZ_CAP_TX_ANTPAT_CONS |
> + IEEE80211_HE_6GHZ_CAP_RX_ANTPAT_CONS),
Seems that needs to be around the *entire* initializer, not just parts
thereof?
The indentation could also use some work :)
johannes
next prev parent reply other threads:[~2021-09-22 14:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 14:28 [PATCH] mac80211_hwsim: enable 6GHz channels Ramon Fontes
2021-09-22 14:29 ` Johannes Berg [this message]
2021-09-24 7:50 ` Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2021-09-23 18:28 Ramon Fontes
2021-09-22 18:15 Ramon Fontes
2021-09-22 14:06 Ramon Fontes
2021-09-06 17:53 Ramon Fontes
2021-09-12 7:49 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167f632eb19944b5711a584218e57b51da85df96.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ramonreisfontes@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).