* [PATCH net] net: wwan: iosm: fixes 7560 modem crash
@ 2023-03-28 6:28 m.chetan.kumar
2023-03-29 8:10 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: m.chetan.kumar @ 2023-03-28 6:28 UTC (permalink / raw)
To: netdev
Cc: kuba, davem, johannes, ryazanov.s.a, loic.poulain,
shaneparslow808, m.chetan.kumar, linuxwwan, M Chetan Kumar,
Martin
From: M Chetan Kumar <m.chetan.kumar@linux.intel.com>
ModemManger/Apps probing the wwan0xmmrpc0 port for 7560 Modem results in
modem crash.
7560 Modem FW uses the MBIM interface for control command communication
whereas 7360 uses Intel RPC interface so disable wwan0xmmrpc0 port for
7560.
Fixes: d08b0f8f46e4 ("net: wwan: iosm: add rpc interface for xmm modems")
Reported-and-tested-by: Martin <mwolf@adiumentum.com>
Link: https://bugzilla.kernel.org/show_bug.cgi?id=217200
Signed-off-by: M Chetan Kumar <m.chetan.kumar@linux.intel.com>
Signed-off-by: Shane Parslow <shaneparslow808@gmail.com>
---
drivers/net/wwan/iosm/iosm_ipc_imem.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/wwan/iosm/iosm_ipc_imem.c b/drivers/net/wwan/iosm/iosm_ipc_imem.c
index 1e6a47976642..c066b0040a3f 100644
--- a/drivers/net/wwan/iosm/iosm_ipc_imem.c
+++ b/drivers/net/wwan/iosm/iosm_ipc_imem.c
@@ -587,6 +587,13 @@ static void ipc_imem_run_state_worker(struct work_struct *instance)
while (ctrl_chl_idx < IPC_MEM_MAX_CHANNELS) {
if (!ipc_chnl_cfg_get(&chnl_cfg_port, ctrl_chl_idx)) {
ipc_imem->ipc_port[ctrl_chl_idx] = NULL;
+
+ if (ipc_imem->pcie->pci->device == INTEL_CP_DEVICE_7560_ID &&
+ chnl_cfg_port.wwan_port_type == WWAN_PORT_XMMRPC) {
+ ctrl_chl_idx++;
+ continue;
+ }
+
if (ipc_imem->pcie->pci->device == INTEL_CP_DEVICE_7360_ID &&
chnl_cfg_port.wwan_port_type == WWAN_PORT_MBIM) {
ctrl_chl_idx++;
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] net: wwan: iosm: fixes 7560 modem crash
2023-03-28 6:28 [PATCH net] net: wwan: iosm: fixes 7560 modem crash m.chetan.kumar
@ 2023-03-29 8:10 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-03-29 8:10 UTC (permalink / raw)
To: Kumar, M Chetan
Cc: netdev, kuba, davem, johannes, ryazanov.s.a, loic.poulain,
shaneparslow808, m.chetan.kumar, linuxwwan, mwolf
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Tue, 28 Mar 2023 11:58:44 +0530 you wrote:
> From: M Chetan Kumar <m.chetan.kumar@linux.intel.com>
>
> ModemManger/Apps probing the wwan0xmmrpc0 port for 7560 Modem results in
> modem crash.
>
> 7560 Modem FW uses the MBIM interface for control command communication
> whereas 7360 uses Intel RPC interface so disable wwan0xmmrpc0 port for
> 7560.
>
> [...]
Here is the summary with links:
- [net] net: wwan: iosm: fixes 7560 modem crash
https://git.kernel.org/netdev/net/c/5f70bcbca469
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-29 8:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-28 6:28 [PATCH net] net: wwan: iosm: fixes 7560 modem crash m.chetan.kumar
2023-03-29 8:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).