* [PATCH net-next v2] smsc911x: remove superfluous variable init
@ 2023-03-29 6:44 Wolfram Sang
2023-03-30 13:40 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Wolfram Sang @ 2023-03-29 6:44 UTC (permalink / raw)
To: netdev
Cc: linux-renesas-soc, Wolfram Sang, Geert Uytterhoeven,
Steve Glendinning, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, linux-kernel
phydev is assigned a value right away, no need to initialize it.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Changes since v1:
* rebased to net-next as of today
* added Geert's tag (thanks!)
drivers/net/ethernet/smsc/smsc911x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/smsc/smsc911x.c b/drivers/net/ethernet/smsc/smsc911x.c
index 39446d4e94b6..c653ea792dd1 100644
--- a/drivers/net/ethernet/smsc/smsc911x.c
+++ b/drivers/net/ethernet/smsc/smsc911x.c
@@ -1016,7 +1016,7 @@ static void smsc911x_phy_adjust_link(struct net_device *dev)
static int smsc911x_mii_probe(struct net_device *dev)
{
struct smsc911x_data *pdata = netdev_priv(dev);
- struct phy_device *phydev = NULL;
+ struct phy_device *phydev;
int ret;
/* find the first phy */
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next v2] smsc911x: remove superfluous variable init
2023-03-29 6:44 [PATCH net-next v2] smsc911x: remove superfluous variable init Wolfram Sang
@ 2023-03-30 13:40 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-03-30 13:40 UTC (permalink / raw)
To: Wolfram Sang
Cc: netdev, linux-renesas-soc, geert+renesas, steve.glendinning,
davem, edumazet, kuba, pabeni, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Wed, 29 Mar 2023 08:44:14 +0200 you wrote:
> phydev is assigned a value right away, no need to initialize it.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>
> Changes since v1:
> * rebased to net-next as of today
> * added Geert's tag (thanks!)
>
> [...]
Here is the summary with links:
- [net-next,v2] smsc911x: remove superfluous variable init
https://git.kernel.org/netdev/net-next/c/da617cd8d906
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-30 13:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-29 6:44 [PATCH net-next v2] smsc911x: remove superfluous variable init Wolfram Sang
2023-03-30 13:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).