From: Sergej Bauer <sbauer@blackbox.su>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Bryan Whitehead <bryan.whitehead@microchip.com>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Rob Herring <robh@kernel.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] add virtual PHY for PHY-less devices
Date: Fri, 18 Sep 2020 03:17:14 +0300 [thread overview]
Message-ID: <1680322.qRJ2Tc3Qy1@metabook> (raw)
In-Reply-To: <20200917221547.GD3598897@lunn.ch>
Hi Andrew
To tell the truth, I thought that fixed_phy is only for devices with a Device
Trees and I never met DTS on x86 machines...
So it looks like there realy no any significant advantage _except_ of
ability to use ethtool and ioctl to set speed and rx-all/fcs flags without
removing module. That was most wanted request from HW designers as they are
wanted to change registers of virtual PHY on-the-fly with ethtool either custom
tool (using SIOCSMIIREG ioctl) for controling PHY registers.
p.s. And that's my bad, the original driver was developed year ago (for
linux-5.2.15),
but I had no time before this moment.
p.p.s. sorry for long time to answer but it's far behind the midnight in my
region.
--
Sergej
On Friday, September 18, 2020 1:15:47 AM MSK Andrew Lunn wrote:
> On Fri, Sep 18, 2020 at 12:40:10AM +0300, Sergej Bauer wrote:
> > From: sbauer@blackbox.su
> >
> > Here is a kernel related part of my work which was helps to develop
> > brand
> >
> > new PHY device.
> >
> > It is migth be helpful for developers work with PHY-less lan743x
> >
> > (7431:0011 in my case). It's just a fake virtual PHY which can change
> > speed of network card processing as a loopback device. Baud rate can be
> > tuned with ethtool from command line or by means of SIOCSMIIREG ioctl.
> > Duplex mode not configurable and it's allways DUPLEX_FULL.
>
> Hi Sergej
>
> What is the advantage of this over using driver/net/phy/fixed_phy.c
> which also emulates a standard PHY?
>
> Andrew
next prev parent reply other threads:[~2020-09-18 0:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 21:40 [PATCH] add virtual PHY for PHY-less devices Sergej Bauer
2020-09-17 22:15 ` Andrew Lunn
2020-09-18 0:17 ` Sergej Bauer [this message]
2020-09-18 1:31 ` Florian Fainelli
2020-09-17 22:16 ` Florian Fainelli
2020-09-18 0:58 ` Sergej Bauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1680322.qRJ2Tc3Qy1@metabook \
--to=sbauer@blackbox.su \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=bryan.whitehead@microchip.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).