netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net: ti/cpsw: Add explicit platform_device.h and of_platform.h includes
@ 2023-04-10 23:27 Rob Herring
  2023-04-11 15:38 ` Jesse Brandeburg
  2023-04-12 10:00 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring @ 2023-04-10 23:27 UTC (permalink / raw)
  To: Grygorii Strashko, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni
  Cc: linux-omap, netdev, linux-kernel

TI CPSW uses of_platform_* functions which are declared in of_platform.h.
of_platform.h gets implicitly included by of_device.h, but that is going
to be removed soon. Nothing else depends on of_device.h so it can be
dropped. of_platform.h also implicitly includes platform_device.h, so
add an explicit include for it, too.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 drivers/net/ethernet/ti/cpsw.c     | 2 +-
 drivers/net/ethernet/ti/cpsw_new.c | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
index 37f0b62ec5d6..f9cd566d1c9b 100644
--- a/drivers/net/ethernet/ti/cpsw.c
+++ b/drivers/net/ethernet/ti/cpsw.c
@@ -27,7 +27,7 @@
 #include <linux/of.h>
 #include <linux/of_mdio.h>
 #include <linux/of_net.h>
-#include <linux/of_device.h>
+#include <linux/of_platform.h>
 #include <linux/if_vlan.h>
 #include <linux/kmemleak.h>
 #include <linux/sys_soc.h>
diff --git a/drivers/net/ethernet/ti/cpsw_new.c b/drivers/net/ethernet/ti/cpsw_new.c
index 35128dd45ffc..c61e4e44a78f 100644
--- a/drivers/net/ethernet/ti/cpsw_new.c
+++ b/drivers/net/ethernet/ti/cpsw_new.c
@@ -7,6 +7,7 @@
 
 #include <linux/io.h>
 #include <linux/clk.h>
+#include <linux/platform_device.h>
 #include <linux/timer.h>
 #include <linux/module.h>
 #include <linux/irqreturn.h>
@@ -23,7 +24,7 @@
 #include <linux/of.h>
 #include <linux/of_mdio.h>
 #include <linux/of_net.h>
-#include <linux/of_device.h>
+#include <linux/of_platform.h>
 #include <linux/if_vlan.h>
 #include <linux/kmemleak.h>
 #include <linux/sys_soc.h>
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] net: ti/cpsw: Add explicit platform_device.h and of_platform.h includes
  2023-04-10 23:27 [PATCH] net: ti/cpsw: Add explicit platform_device.h and of_platform.h includes Rob Herring
@ 2023-04-11 15:38 ` Jesse Brandeburg
  2023-04-12 10:00 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Jesse Brandeburg @ 2023-04-11 15:38 UTC (permalink / raw)
  To: Rob Herring, Grygorii Strashko, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni
  Cc: linux-omap, netdev, linux-kernel

On 4/10/2023 4:27 PM, Rob Herring wrote:
> TI CPSW uses of_platform_* functions which are declared in of_platform.h.
> of_platform.h gets implicitly included by of_device.h, but that is going
> to be removed soon. Nothing else depends on of_device.h so it can be
> dropped. of_platform.h also implicitly includes platform_device.h, so
> add an explicit include for it, too.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] net: ti/cpsw: Add explicit platform_device.h and of_platform.h includes
  2023-04-10 23:27 [PATCH] net: ti/cpsw: Add explicit platform_device.h and of_platform.h includes Rob Herring
  2023-04-11 15:38 ` Jesse Brandeburg
@ 2023-04-12 10:00 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-04-12 10:00 UTC (permalink / raw)
  To: Rob Herring
  Cc: grygorii.strashko, davem, edumazet, kuba, pabeni, linux-omap,
	netdev, linux-kernel

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:

On Mon, 10 Apr 2023 18:27:19 -0500 you wrote:
> TI CPSW uses of_platform_* functions which are declared in of_platform.h.
> of_platform.h gets implicitly included by of_device.h, but that is going
> to be removed soon. Nothing else depends on of_device.h so it can be
> dropped. of_platform.h also implicitly includes platform_device.h, so
> add an explicit include for it, too.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> 
> [...]

Here is the summary with links:
  - net: ti/cpsw: Add explicit platform_device.h and of_platform.h includes
    https://git.kernel.org/netdev/net/c/136f36c74b03

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-04-12 10:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-10 23:27 [PATCH] net: ti/cpsw: Add explicit platform_device.h and of_platform.h includes Rob Herring
2023-04-11 15:38 ` Jesse Brandeburg
2023-04-12 10:00 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).