RE: [PATCH bpf-next V2 0/5] XDP-hints: XDP kfunc metadata for driver igc

Song, Yoong Siang
2023-04-18T14:55:55Z

On Tuesday, April 18, 2023 9:31 PM, Jesper Dangaard Brouer <brouer@redhat.com> wrote:
>Implement both RX hash and RX timestamp XDP hints kfunc metadata for driver
>igc.
>
>First patch fix RX hashing for igc in general.
>
>Last patch change test program xdp_hw_metadata to track more timestamps,
>which helps us correlate the hardware RX timestamp with something.
>
>---
>To maintainers: I'm uncertain which git tree this should be sent against. This is
>primary NIC driver code (net-next), but it's BPF/XDP related (bpf-next) via
>xdp_metadata_ops.
>
>Jesper Dangaard Brouer (5):
> igc: enable and fix RX hash usage by netstack
> igc: add igc_xdp_buff wrapper for xdp_buff in driver
> igc: add XDP hints kfuncs for RX hash
> igc: add XDP hints kfuncs for RX timestamp
> selftests/bpf: xdp_hw_metadata track more timestamps
>
>
> drivers/net/ethernet/intel/igc/igc.h | 35 ++++++
> drivers/net/ethernet/intel/igc/igc_main.c | 116 ++++++++++++++++--
> .../selftests/bpf/progs/xdp_hw_metadata.c | 4 +-
> tools/testing/selftests/bpf/xdp_hw_metadata.c | 47 ++++++-
> tools/testing/selftests/bpf/xdp_metadata.h | 1 +
> 5 files changed, 186 insertions(+), 17 deletions(-)
>
>--

This patchset lgtm.
Thanks for the changes.

Thanks & Regards
Siang