From: patchwork-bot+netdevbpf@kernel.org
To: Saeed Mahameed <saeed@kernel.org>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, saeedm@nvidia.com, netdev@vger.kernel.org,
tariqt@nvidia.com, vladbu@nvidia.com, roid@nvidia.com
Subject: Re: [net V2 01/10] net/mlx5e: Don't clone flow post action attributes second time
Date: Sat, 22 Apr 2023 03:50:20 +0000 [thread overview]
Message-ID: <168213542073.31717.3866727182906999762.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230421015057.355468-2-saeed@kernel.org>
Hello:
This series was applied to netdev/net.git (main)
by Saeed Mahameed <saeedm@nvidia.com>:
On Thu, 20 Apr 2023 18:50:48 -0700 you wrote:
> From: Vlad Buslov <vladbu@nvidia.com>
>
> The code already clones post action attributes in
> mlx5e_clone_flow_attr_for_post_act(). Creating another copy in
> mlx5e_tc_post_act_add() is a erroneous leftover from original
> implementation. Instead, assign handle->attribute to post_attr provided by
> the caller. Note that cloning the attribute second time is not just
> wasteful but also causes issues like second copy not being properly updated
> in neigh update code which leads to following use-after-free:
>
> [...]
Here is the summary with links:
- [net,V2,01/10] net/mlx5e: Don't clone flow post action attributes second time
https://git.kernel.org/netdev/net/c/e9fce818fe00
- [net,V2,02/10] net/mlx5e: Release the label when replacing existing ct entry
https://git.kernel.org/netdev/net/c/8ac04a28144c
- [net,V2,03/10] net/mlx5: E-switch, Create per vport table based on devlink encap mode
https://git.kernel.org/netdev/net/c/fd745f4c0abe
- [net,V2,04/10] net/mlx5: E-switch, Don't destroy indirect table in split rule
https://git.kernel.org/netdev/net/c/4c8189302567
- [net,V2,05/10] net/mlx5: Release tunnel device after tc update skb
https://git.kernel.org/netdev/net/c/4fbef0f8ea63
- [net,V2,06/10] net/mlx5e: Fix error flow in representor failing to add vport rx rule
https://git.kernel.org/netdev/net/c/0a6b069cc60d
- [net,V2,07/10] Revert "net/mlx5: Remove "recovery" arg from mlx5_load_one() function"
https://git.kernel.org/netdev/net/c/21608a2cf38e
- [net,V2,08/10] net/mlx5: Use recovery timeout on sync reset flow
https://git.kernel.org/netdev/net/c/dfad99750c0f
- [net,V2,09/10] net/mlx5e: Nullify table pointer when failing to create
https://git.kernel.org/netdev/net/c/1b540decd03a
- [net,V2,10/10] Revert "net/mlx5e: Don't use termination table when redundant"
https://git.kernel.org/netdev/net/c/081abcacaf0a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
next prev parent reply other threads:[~2023-04-22 3:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-21 1:50 [pull request][net V2 00/10] mlx5 fixes 2023-04-19 Saeed Mahameed
2023-04-21 1:50 ` [net V2 01/10] net/mlx5e: Don't clone flow post action attributes second time Saeed Mahameed
2023-04-22 3:50 ` patchwork-bot+netdevbpf [this message]
2023-04-21 1:50 ` [net V2 02/10] net/mlx5e: Release the label when replacing existing ct entry Saeed Mahameed
2023-04-21 1:50 ` [net V2 03/10] net/mlx5: E-switch, Create per vport table based on devlink encap mode Saeed Mahameed
2023-04-21 1:50 ` [net V2 04/10] net/mlx5: E-switch, Don't destroy indirect table in split rule Saeed Mahameed
2023-04-21 1:50 ` [net V2 05/10] net/mlx5: Release tunnel device after tc update skb Saeed Mahameed
2023-04-21 1:50 ` [net V2 06/10] net/mlx5e: Fix error flow in representor failing to add vport rx rule Saeed Mahameed
2023-04-21 1:50 ` [net V2 07/10] Revert "net/mlx5: Remove "recovery" arg from mlx5_load_one() function" Saeed Mahameed
2023-04-21 1:50 ` [net V2 08/10] net/mlx5: Use recovery timeout on sync reset flow Saeed Mahameed
2023-04-21 1:50 ` [net V2 09/10] net/mlx5e: Nullify table pointer when failing to create Saeed Mahameed
2023-04-21 1:50 ` [net V2 10/10] Revert "net/mlx5e: Don't use termination table when redundant" Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168213542073.31717.3866727182906999762.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=roid@nvidia.com \
--cc=saeed@kernel.org \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=vladbu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).