[PATCH v5] net: amd: Fix link leak when verifying config failed

[PATCH v5] net: amd: Fix link leak when verifying config failed

[Gencen Gan]

After failing to verify configuration, it returns directly without
releasing link, which may cause memory leak.

Paolo Abeni thinks that the whole code of this driver is quite 
"suboptimal" and looks unmainatained since at least ~15y, so he 
suggests that we could simply remove the whole driver, please 
take it into consideration.

Simon Horman suggests that the fix label should be set to 
"Linux-2.6.12-rc2" considering that the problem has existed
since the driver was introduced and the commit above doesn't
seem to exist in net/net-next.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Gan Gecen <gangecen@hust.edu.cn>
Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
---
v4->v5: I have made some mistakes on patch rules, sorry for that.
v3->v4: Modify the 'Fixes:' tag to make it more accurate.
v2->v3: Add Fixes tag and add a suggestion about this driver.
v1->v2: Fix the whitespace-damaged bug.
 drivers/net/ethernet/amd/nmclan_cs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/amd/nmclan_cs.c b/drivers/net/ethernet/amd/nmclan_cs.c
index 823a329a921f..0dd391c84c13 100644
--- a/drivers/net/ethernet/amd/nmclan_cs.c
+++ b/drivers/net/ethernet/amd/nmclan_cs.c
@@ -651,7 +651,7 @@ static int nmclan_config(struct pcmcia_device *link)
     } else {
       pr_notice("mace id not found: %x %x should be 0x40 0x?9\n",
 		sig[0], sig[1]);
-      return -ENODEV;
+      goto failed;
     }
   }
 
-- 
2.34.1

Re: [PATCH v5] net: amd: Fix link leak when verifying config failed

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:

On Mon, 24 Apr 2023 23:28:01 +0800 you wrote:
> After failing to verify configuration, it returns directly without
> releasing link, which may cause memory leak.
> 
> Paolo Abeni thinks that the whole code of this driver is quite
> "suboptimal" and looks unmainatained since at least ~15y, so he
> suggests that we could simply remove the whole driver, please
> take it into consideration.
> 
> [...]

Here is the summary with links:
  - [v5] net: amd: Fix link leak when verifying config failed
    https://git.kernel.org/netdev/net/c/d325c34d9e7e

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html