* [PATCH net] ionic: remove noise from ethtool rxnfc error msg
@ 2023-05-02 18:47 Shannon Nelson
2023-05-02 20:01 ` Simon Horman
2023-05-03 8:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Shannon Nelson @ 2023-05-02 18:47 UTC (permalink / raw)
To: kuba, davem, netdev; +Cc: drivers, Shannon Nelson
It seems that ethtool is calling into .get_rxnfc more often with
ETHTOOL_GRXCLSRLCNT which ionic doesn't know about. We don't
need to log a message about it, just return not supported.
Fixes: aa3198819bea6 ("ionic: Add RSS support")
Signed-off-by: Shannon Nelson <shannon.nelson@amd.com>
---
drivers/net/ethernet/pensando/ionic/ionic_ethtool.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c b/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
index cf33503468a3..9b2b96fa36af 100644
--- a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
+++ b/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
@@ -794,7 +794,7 @@ static int ionic_get_rxnfc(struct net_device *netdev,
info->data = lif->nxqs;
break;
default:
- netdev_err(netdev, "Command parameter %d is not supported\n",
+ netdev_dbg(netdev, "Command parameter %d is not supported\n",
info->cmd);
err = -EOPNOTSUPP;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net] ionic: remove noise from ethtool rxnfc error msg
2023-05-02 18:47 [PATCH net] ionic: remove noise from ethtool rxnfc error msg Shannon Nelson
@ 2023-05-02 20:01 ` Simon Horman
2023-05-03 8:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2023-05-02 20:01 UTC (permalink / raw)
To: Shannon Nelson; +Cc: kuba, davem, netdev, drivers
On Tue, May 02, 2023 at 11:47:40AM -0700, Shannon Nelson wrote:
> It seems that ethtool is calling into .get_rxnfc more often with
> ETHTOOL_GRXCLSRLCNT which ionic doesn't know about. We don't
> need to log a message about it, just return not supported.
>
> Fixes: aa3198819bea6 ("ionic: Add RSS support")
> Signed-off-by: Shannon Nelson <shannon.nelson@amd.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net] ionic: remove noise from ethtool rxnfc error msg
2023-05-02 18:47 [PATCH net] ionic: remove noise from ethtool rxnfc error msg Shannon Nelson
2023-05-02 20:01 ` Simon Horman
@ 2023-05-03 8:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-05-03 8:10 UTC (permalink / raw)
To: Shannon Nelson; +Cc: kuba, davem, netdev, drivers
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Tue, 2 May 2023 11:47:40 -0700 you wrote:
> It seems that ethtool is calling into .get_rxnfc more often with
> ETHTOOL_GRXCLSRLCNT which ionic doesn't know about. We don't
> need to log a message about it, just return not supported.
>
> Fixes: aa3198819bea6 ("ionic: Add RSS support")
> Signed-off-by: Shannon Nelson <shannon.nelson@amd.com>
>
> [...]
Here is the summary with links:
- [net] ionic: remove noise from ethtool rxnfc error msg
https://git.kernel.org/netdev/net/c/3711d44fac1f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-03 8:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-02 18:47 [PATCH net] ionic: remove noise from ethtool rxnfc error msg Shannon Nelson
2023-05-02 20:01 ` Simon Horman
2023-05-03 8:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).