From: patchwork-bot+netdevbpf@kernel.org
To: Ido Schimmel <idosch@nvidia.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
pabeni@redhat.com, edumazet@google.com, danieller@nvidia.com,
mlxsw@nvidia.com
Subject: Re: [PATCH net] ethtool: Fix uninitialized number of lanes
Date: Wed, 03 May 2023 08:20:21 +0000 [thread overview]
Message-ID: <168310202124.22454.13945309263384603671.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230502122050.917205-1-idosch@nvidia.com>
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Tue, 2 May 2023 15:20:50 +0300 you wrote:
> It is not possible to set the number of lanes when setting link modes
> using the legacy IOCTL ethtool interface. Since 'struct
> ethtool_link_ksettings' is not initialized in this path, drivers receive
> an uninitialized number of lanes in 'struct
> ethtool_link_ksettings::lanes'.
>
> When this information is later queried from drivers, it results in the
> ethtool code making decisions based on uninitialized memory, leading to
> the following KMSAN splat [1]. In practice, this most likely only
> happens with the tun driver that simply returns whatever it got in the
> set operation.
>
> [...]
Here is the summary with links:
- [net] ethtool: Fix uninitialized number of lanes
https://git.kernel.org/netdev/net/c/9ad685dbfe7e
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-05-03 8:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-02 12:20 [PATCH net] ethtool: Fix uninitialized number of lanes Ido Schimmel
2023-05-02 13:03 ` Leon Romanovsky
2023-05-03 8:20 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168310202124.22454.13945309263384603671.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=danieller@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox