From: patchwork-bot+netdevbpf@kernel.org
To: Jakub Kicinski <kuba@kernel.org>
Cc: mkubecek@suse.cz, netdev@vger.kernel.org, piergiorgio.beruto@gmail.com
Subject: Re: [PATCH ethtool] netlink: settings: fix netlink support when PLCA is not present
Date: Sun, 07 May 2023 22:40:19 +0000 [thread overview]
Message-ID: <168349921994.21680.17516407930651873486.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230425000742.130480-1-kuba@kernel.org>
Hello:
This patch was applied to ethtool/ethtool.git (master)
by Michal Kubecek <mkubecek@suse.cz>:
On Mon, 24 Apr 2023 17:07:42 -0700 you wrote:
> PLCA support threw the PLCA commands as required into the initial
> support check at the start of nl_gset(). That's not correct.
> The initial check (AFAIU) queries for the base support in the kernel
> i.e. support for the commands which correspond to ioctls.
> If those are not available (presumably very old kernel or kernel
> without ethtool-netlink) we're better off using the ioctl.
>
> [...]
Here is the summary with links:
- [ethtool] netlink: settings: fix netlink support when PLCA is not present
https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/commit/?id=3d1f1c1e5070
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-05-07 22:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 0:07 [PATCH ethtool] netlink: settings: fix netlink support when PLCA is not present Jakub Kicinski
2023-04-25 10:33 ` Piergiorgio Beruto
2023-04-25 14:40 ` Piergiorgio Beruto
2023-04-25 15:34 ` Jakub Kicinski
2023-05-07 22:40 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168349921994.21680.17516407930651873486.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=kuba@kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=piergiorgio.beruto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).