From: patchwork-bot+netdevbpf@kernel.org
To: Simon Horman <horms@kernel.org>
Cc: kuba@kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, j.vosburgh@gmail.com, andy@greyhouse.net,
olteanv@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2] bonding: Always assign be16 value to vlan_proto
Date: Fri, 12 May 2023 08:40:19 +0000 [thread overview]
Message-ID: <168388081993.5500.5871554155408487884.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230420-bonding-be-vlan-proto-v2-1-9f594fabdbd9@kernel.org>
Hello:
This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:
On Thu, 11 May 2023 17:07:12 +0200 you wrote:
> The type of the vlan_proto field is __be16.
> And most users of the field use it as such.
>
> In the case of setting or testing the field for the special VLAN_N_VID
> value, host byte order is used. Which seems incorrect.
>
> It also seems somewhat odd to store a VLAN ID value in a field that is
> otherwise used to store Ether types.
>
> [...]
Here is the summary with links:
- [net-next,v2] bonding: Always assign be16 value to vlan_proto
https://git.kernel.org/netdev/net-next/c/c1bc7d73c964
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-05-12 8:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-11 15:07 [PATCH net-next v2] bonding: Always assign be16 value to vlan_proto Simon Horman
2023-05-11 23:43 ` Jay Vosburgh
2023-05-12 9:28 ` Simon Horman
2023-05-12 9:30 ` Simon Horman
2023-05-12 8:40 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168388081993.5500.5871554155408487884.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=j.vosburgh@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).