* [PATCH] net/pppoe: fix a typo for the PPPOE_HASH_BITS_1 definition
@ 2023-06-05 7:27 Lukas Bulwahn
2023-06-05 12:16 ` Simon Horman
2023-06-06 11:40 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 4+ messages in thread
From: Lukas Bulwahn @ 2023-06-05 7:27 UTC (permalink / raw)
To: Jaco Kroon, David S . Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, netdev
Cc: kernel-janitors, linux-kernel, Lukas Bulwahn
Instead of its intention to define PPPOE_HASH_BITS_1, commit 96ba44c637b0
("net/pppoe: make number of hash bits configurable") actually defined
config PPPOE_HASH_BITS_2 twice in the ppp's Kconfig file due to a quick
typo with the numbers.
Fix the typo and define PPPOE_HASH_BITS_1.
Fixes: 96ba44c637b0 ("net/pppoe: make number of hash bits configurable")
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
drivers/net/ppp/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ppp/Kconfig b/drivers/net/ppp/Kconfig
index 2fbcae31fc02..8c9ed1889d1a 100644
--- a/drivers/net/ppp/Kconfig
+++ b/drivers/net/ppp/Kconfig
@@ -141,7 +141,7 @@ choice
This hash table is on a per outer ethernet interface.
-config PPPOE_HASH_BITS_2
+config PPPOE_HASH_BITS_1
bool "1 bit (2 buckets)"
config PPPOE_HASH_BITS_2
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] net/pppoe: fix a typo for the PPPOE_HASH_BITS_1 definition
2023-06-05 7:27 [PATCH] net/pppoe: fix a typo for the PPPOE_HASH_BITS_1 definition Lukas Bulwahn
@ 2023-06-05 12:16 ` Simon Horman
2023-06-05 14:47 ` Jaco Kroon
2023-06-06 11:40 ` patchwork-bot+netdevbpf
1 sibling, 1 reply; 4+ messages in thread
From: Simon Horman @ 2023-06-05 12:16 UTC (permalink / raw)
To: Lukas Bulwahn
Cc: Jaco Kroon, David S . Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, netdev, kernel-janitors, linux-kernel
On Mon, Jun 05, 2023 at 09:27:43AM +0200, Lukas Bulwahn wrote:
> Instead of its intention to define PPPOE_HASH_BITS_1, commit 96ba44c637b0
> ("net/pppoe: make number of hash bits configurable") actually defined
> config PPPOE_HASH_BITS_2 twice in the ppp's Kconfig file due to a quick
> typo with the numbers.
>
> Fix the typo and define PPPOE_HASH_BITS_1.
>
> Fixes: 96ba44c637b0 ("net/pppoe: make number of hash bits configurable")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net/pppoe: fix a typo for the PPPOE_HASH_BITS_1 definition
2023-06-05 12:16 ` Simon Horman
@ 2023-06-05 14:47 ` Jaco Kroon
0 siblings, 0 replies; 4+ messages in thread
From: Jaco Kroon @ 2023-06-05 14:47 UTC (permalink / raw)
To: Simon Horman, Lukas Bulwahn
Cc: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
netdev, kernel-janitors, linux-kernel
On 2023/06/05 14:16, Simon Horman wrote:
> On Mon, Jun 05, 2023 at 09:27:43AM +0200, Lukas Bulwahn wrote:
>> Instead of its intention to define PPPOE_HASH_BITS_1, commit 96ba44c637b0
>> ("net/pppoe: make number of hash bits configurable") actually defined
>> config PPPOE_HASH_BITS_2 twice in the ppp's Kconfig file due to a quick
>> typo with the numbers.
>>
>> Fix the typo and define PPPOE_HASH_BITS_1.
>>
>> Fixes: 96ba44c637b0 ("net/pppoe: make number of hash bits configurable")
>> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> Reviewed-by: Simon Horman <simon.horman@corigine.com>
>
Reviewed-by: Jaco Kroon <jaco@uls.co.za>
Sorry about that, that was indeed blonde. Thanks for the fixup.
Kind Regards,
Jaco
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net/pppoe: fix a typo for the PPPOE_HASH_BITS_1 definition
2023-06-05 7:27 [PATCH] net/pppoe: fix a typo for the PPPOE_HASH_BITS_1 definition Lukas Bulwahn
2023-06-05 12:16 ` Simon Horman
@ 2023-06-06 11:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-06-06 11:40 UTC (permalink / raw)
To: Lukas Bulwahn
Cc: jaco, davem, edumazet, kuba, pabeni, netdev, kernel-janitors,
linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Mon, 5 Jun 2023 09:27:43 +0200 you wrote:
> Instead of its intention to define PPPOE_HASH_BITS_1, commit 96ba44c637b0
> ("net/pppoe: make number of hash bits configurable") actually defined
> config PPPOE_HASH_BITS_2 twice in the ppp's Kconfig file due to a quick
> typo with the numbers.
>
> Fix the typo and define PPPOE_HASH_BITS_1.
>
> [...]
Here is the summary with links:
- net/pppoe: fix a typo for the PPPOE_HASH_BITS_1 definition
https://git.kernel.org/netdev/net-next/c/ae91f7e436f8
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-06 11:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-05 7:27 [PATCH] net/pppoe: fix a typo for the PPPOE_HASH_BITS_1 definition Lukas Bulwahn
2023-06-05 12:16 ` Simon Horman
2023-06-05 14:47 ` Jaco Kroon
2023-06-06 11:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).