From: patchwork-bot+netdevbpf@kernel.org
To: Fedor Pchelkin <pchelkin@ispras.ru>
Cc: davem@davemloft.net, sd@queasysnail.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, raeds@nvidia.com,
liorna@nvidia.com, saeedm@nvidia.com, hannes@stressinduktion.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
khoroshilov@ispras.ru, lvc-project@linuxtesting.org
Subject: Re: [PATCH] net: macsec: fix double free of percpu stats
Date: Thu, 15 Jun 2023 10:50:20 +0000 [thread overview]
Message-ID: <168682622021.15431.8579667893782171995.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230613192220.159407-1-pchelkin@ispras.ru>
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Tue, 13 Jun 2023 22:22:20 +0300 you wrote:
> Inside macsec_add_dev() we free percpu macsec->secy.tx_sc.stats and
> macsec->stats on some of the memory allocation failure paths. However, the
> net_device is already registered to that moment: in macsec_newlink(), just
> before calling macsec_add_dev(). This means that during unregister process
> its priv_destructor - macsec_free_netdev() - will be called and will free
> the stats again.
>
> [...]
Here is the summary with links:
- net: macsec: fix double free of percpu stats
https://git.kernel.org/netdev/net/c/0c0cf3db83f8
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-06-15 10:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 19:22 [PATCH] net: macsec: fix double free of percpu stats Fedor Pchelkin
2023-06-14 3:01 ` Jakub Kicinski
2023-06-14 12:26 ` Sabrina Dubroca
2023-06-14 16:01 ` Jakub Kicinski
2023-06-14 20:17 ` Fedor Pchelkin
2023-06-14 21:15 ` Sabrina Dubroca
2023-06-15 6:02 ` Jakub Kicinski
2023-06-15 7:07 ` Sabrina Dubroca
2023-06-15 10:50 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168682622021.15431.8579667893782171995.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hannes@stressinduktion.org \
--cc=khoroshilov@ispras.ru \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liorna@nvidia.com \
--cc=lvc-project@linuxtesting.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pchelkin@ispras.ru \
--cc=raeds@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).