netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Robert Olsson <Robert.Olsson@data.slu.se>
To: jeremy.guthrie@berbee.com
Cc: netdev@oss.sgi.com, Robert Olsson <Robert.Olsson@data.slu.se>,
	Stephen Hemminger <shemminger@osdl.org>,
	Jesse Brandeburg <jesse.brandeburg@intel.com>
Subject: Re: V2.4 policy router operates faster/better than V2.6
Date: Wed, 12 Jan 2005 20:27:40 +0100	[thread overview]
Message-ID: <16869.31276.256679.96845@robur.slu.se> (raw)
In-Reply-To: <200501121025.03899.jeremy.guthrie@berbee.com>


Jeremy M. Guthrie writes:

 > >  > ETH3 Interrupts(calc'd from below):  1479968

 > >  Very strange...
 > >
 > >  eth3 is bound to CPU0 which in turn has all packet load... If we were
 > >  to believe your CPU0 was saturated (due to the drops). We should see no
 > >  (RX) interrupts on eth3. But there is a lot... one irq per every three
 > >  packet. Why?

 > I have no idea why it would be doing this.

 Huh seems you didn't add the patch I sent. Below is diff from my editor to your
 e1000_main.c

							--ro


--- e1000_main.c.jmg	2005-01-12 20:14:08.324168072 +0100
+++ e1000_main.c	2005-01-12 20:17:24.777302656 +0100
@@ -2264,14 +2264,13 @@
 	netdev->quota -= work_done;
 	
 	/* if no Rx and Tx cleanup work was done, exit the polling mode */
-	if(!tx_cleaned || (work_done < work_to_do) || 
-				!netif_running(netdev)) {
+	 if( (!tx_cleaned && (work_done == 0)) || !netif_running(netdev)) {
 quit_polling:	netif_rx_complete(netdev);
 		e1000_irq_enable(adapter);
 		return 0;
 	}
 
-	return (work_done >= work_to_do);
+	return 1;
 }
 
 #endif

  reply	other threads:[~2005-01-12 19:27 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-03 20:55 V2.4 policy router operates faster/better than V2.6 Jeremy M. Guthrie
2005-01-03 22:51 ` Stephen Hemminger
2005-01-03 22:56   ` Jeremy M. Guthrie
2005-01-05 13:18     ` Robert Olsson
2005-01-05 15:18       ` Jeremy M. Guthrie
2005-01-05 16:30         ` Robert Olsson
2005-01-05 17:35           ` Jeremy M. Guthrie
2005-01-05 19:25             ` Jeremy M. Guthrie
2005-01-05 20:22               ` Robert Olsson
2005-01-05 20:52                 ` Jeremy M. Guthrie
2005-01-06 15:26                 ` Jeremy M. Guthrie
2005-01-06 18:15                   ` Robert Olsson
2005-01-06 19:35                     ` Jeremy M. Guthrie
2005-01-06 20:29                       ` Robert Olsson
2005-01-06 20:54                         ` Jeremy M. Guthrie
2005-01-06 20:55                         ` Jeremy M. Guthrie
2005-01-06 21:19                         ` Jeremy M. Guthrie
2005-01-06 21:36                           ` Robert Olsson
2005-01-06 21:46                             ` Jeremy M. Guthrie
2005-01-06 22:11                               ` Robert Olsson
2005-01-06 22:18                                 ` Jeremy M. Guthrie
2005-01-06 22:35                                   ` Robert Olsson
2005-01-07 16:17                                     ` Jeremy M. Guthrie
2005-01-07 19:18                                       ` Robert Olsson
2005-01-07 19:38                                         ` Jeremy M. Guthrie
2005-01-07 20:07                                           ` Robert Olsson
2005-01-07 20:14                                           ` Jeremy M. Guthrie
2005-01-07 20:40                                             ` Robert Olsson
2005-01-07 21:06                                               ` Jeremy M. Guthrie
2005-01-07 21:30                                                 ` Robert Olsson
2005-01-11 15:11                                                   ` Jeremy M. Guthrie
2005-01-07 22:28                                             ` Jesse Brandeburg
2005-01-07 22:50                                               ` Jeremy M. Guthrie
2005-01-07 22:57                                                 ` Stephen Hemminger
2005-01-11 15:17                                                   ` Jeremy M. Guthrie
2005-01-11 16:40                                                     ` Robert Olsson
2005-01-12  1:27                                                       ` Jeremy M. Guthrie
2005-01-12 15:11                                                         ` Robert Olsson
2005-01-12 16:24                                                           ` Jeremy M. Guthrie
2005-01-12 19:27                                                             ` Robert Olsson [this message]
2005-01-12 20:11                                                               ` Jeremy M. Guthrie
2005-01-12 20:21                                                                 ` Robert Olsson
2005-01-12 20:30                                                                   ` Jeremy M. Guthrie
2005-01-12 20:45                                                                   ` Jeremy M. Guthrie
2005-01-12 22:02                                                                     ` Robert Olsson
2005-01-12 22:21                                                                       ` Jeremy M. Guthrie
     [not found]                                                                         ` <16869.42247.126428.508479@robur.slu.se>
2005-01-12 22:42                                                                           ` Jeremy M. Guthrie
2005-01-12 22:47                                                                           ` Jeremy M. Guthrie
2005-01-12 23:19                                                                             ` Robert Olsson
2005-01-12 23:23                                                                               ` Jeremy M. Guthrie
2005-01-13  8:56                                                                                 ` Robert Olsson
2005-01-13 19:28                                                                                   ` Jeremy M. Guthrie
2005-01-13 20:00                                                                                     ` David S. Miller
2005-01-13 20:43                                                                                       ` Jeremy M. Guthrie
2005-01-13 23:13                                                                                         ` David S. Miller
2005-01-13 21:12                                                                                     ` Robert Olsson
2005-01-13 22:27                                                                                       ` Jeremy M. Guthrie
2005-01-14 15:44                                                                                         ` Robert Olsson
2005-01-14 14:59                                                                                       ` Jeremy M. Guthrie
2005-01-14 16:05                                                                                         ` Robert Olsson
2005-01-14 19:00                                                                                           ` Jeremy M. Guthrie
2005-01-14 19:26                                                                                             ` Jeremy M. Guthrie
2005-01-16 12:32                                                                                               ` Robert Olsson
2005-01-16 16:22                                                                                                 ` Jeremy M. Guthrie
2005-01-19 15:03                                                                                                 ` Jeremy M. Guthrie
2005-01-19 22:18                                                                                                   ` Robert Olsson
2005-01-20  1:50                                                                                                     ` Jeremy M. Guthrie
2005-01-20 11:30                                                                                                       ` Robert Olsson
2005-01-20 14:37                                                                                                         ` Jeremy M. Guthrie
2005-01-20 17:01                                                                                                           ` Robert Olsson
2005-01-20 17:14                                                                                                             ` Jeremy M. Guthrie
2005-01-20 21:53                                                                                                               ` Robert Olsson
2005-01-21 21:20                                                                                                                 ` Jeremy M. Guthrie
2005-01-21 15:23                                                                                                               ` Robert Olsson
2005-01-21 21:24                                                                                                                 ` Jeremy M. Guthrie
2005-01-31 15:37                                                                                                               ` Jeremy M. Guthrie
2005-01-31 18:06                                                                                                                 ` Robert Olsson
2005-01-12 22:05                                                                     ` Jeremy M. Guthrie
2005-01-12 22:22                                                                       ` Robert Olsson
2005-01-12 22:30                                                                         ` Jeremy M. Guthrie
2005-01-11 17:17                                                     ` Jeremy M. Guthrie
2005-01-11 18:46                                                       ` Robert Olsson
2005-01-12  1:30                                                         ` Jeremy M. Guthrie
2005-01-12 16:02                                                           ` Robert Olsson
2005-01-04 15:07   ` Jeremy M. Guthrie
     [not found] <200501071619.54566.jeremy.guthrie@berbee.com>
2005-01-07 23:23 ` Jesse Brandeburg
2005-01-10 21:11   ` Jeremy M. Guthrie
     [not found] <C925F8B43D79CC49ACD0601FB68FF50C02D39006@orsmsx408>
2005-01-13 22:55 ` Jeremy M. Guthrie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16869.31276.256679.96845@robur.slu.se \
    --to=robert.olsson@data.slu.se \
    --cc=jeremy.guthrie@berbee.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=netdev@oss.sgi.com \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).