From: Robert Olsson <Robert.Olsson@data.slu.se>
To: Dave Peterson <dsp@llnl.gov>
Cc: robert.olsson@its.uu.se, netdev@oss.sgi.com
Subject: possible bug in net/core/pktgen.c (2.6.10 kernel)
Date: Sun, 16 Jan 2005 13:46:50 +0100 [thread overview]
Message-ID: <16874.25146.335366.990655@robur.slu.se> (raw)
In-Reply-To: <200501141129.21461.dsp@llnl.gov>
Dave Peterson writes:
> I found a piece of code that looks problematic in the 2.6.10 kernel.
> The following code appears starting on line 746 in function inject()
> of net/core/pktgen.c:
> schedule();
> else
> do_softirq();
Thanks!
So it should be?
--- net/core/pktgen.c.orig 2005-01-16 13:39:10.933427120 +0100
+++ net/core/pktgen.c 2005-01-16 13:40:41.926751672 +0100
@@ -753,8 +753,11 @@
}
if (need_resched())
schedule();
- else
+ else {
+ preempt_disable();
do_softirq();
+ preempt_enable();
+ }
} while (netif_queue_stopped(odev));
idle = cycles() - idle_start;
info->idle_acc += idle;
--ro
next prev parent reply other threads:[~2005-01-16 12:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-14 19:29 possible bug in net/core/pktgen.c (2.6.10 kernel) Dave Peterson
2005-01-16 12:46 ` Robert Olsson [this message]
2005-01-18 17:35 ` Dave Peterson
2005-01-18 20:41 ` David S. Miller
2005-01-18 21:46 ` Dave Peterson
2005-01-18 21:50 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16874.25146.335366.990655@robur.slu.se \
--to=robert.olsson@data.slu.se \
--cc=dsp@llnl.gov \
--cc=netdev@oss.sgi.com \
--cc=robert.olsson@its.uu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).