From: patchwork-bot+netdevbpf@kernel.org
To: David Howells <dhowells@redhat.com>
Cc: netdev@vger.kernel.org, aaptel@nvidia.com, sagi@grimberg.me,
willemb@google.com, kbusch@kernel.org, axboe@fb.com, hch@lst.de,
kch@nvidia.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, axboe@kernel.dk,
willy@infradead.org, linux-nvme@lists.infradead.org
Subject: Re: [PATCH net] nvme-tcp: Fix comma-related oops
Date: Sun, 02 Jul 2023 14:50:22 +0000 [thread overview]
Message-ID: <168830942217.27441.11517289068592385502.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <59062.1688075273@warthog.procyon.org.uk>
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Thu, 29 Jun 2023 22:47:53 +0100 you wrote:
> Fix a comma that should be a semicolon. The comma is at the end of an
> if-body and thus makes the statement after (a bvec_set_page()) conditional
> too, resulting in an oops because we didn't fill out the bio_vec[]:
>
> BUG: kernel NULL pointer dereference, address: 0000000000000008
> #PF: supervisor read access in kernel mode
> #PF: error_code(0x0000) - not-present page
> ...
> Workqueue: nvme_tcp_wq nvme_tcp_io_work [nvme_tcp]
> RIP: 0010:skb_splice_from_iter+0xf1/0x370
> ...
> Call Trace:
> tcp_sendmsg_locked+0x3a6/0xdd0
> tcp_sendmsg+0x31/0x50
> inet_sendmsg+0x47/0x80
> sock_sendmsg+0x99/0xb0
> nvme_tcp_try_send_data+0x149/0x490 [nvme_tcp]
> nvme_tcp_try_send+0x1b7/0x300 [nvme_tcp]
> nvme_tcp_io_work+0x40/0xc0 [nvme_tcp]
> process_one_work+0x21c/0x430
> worker_thread+0x54/0x3e0
> kthread+0xf8/0x130
>
> [...]
Here is the summary with links:
- [net] nvme-tcp: Fix comma-related oops
https://git.kernel.org/netdev/net/c/c97d3fb9e0e7
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-07-02 14:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-29 21:47 [PATCH net] nvme-tcp: Fix comma-related oops David Howells
2023-06-29 23:26 ` Chaitanya Kulkarni
2023-06-30 15:20 ` Keith Busch
2023-06-30 15:33 ` Jakub Kicinski
2023-07-02 14:50 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168830942217.27441.11517289068592385502.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=aaptel@nvidia.com \
--cc=axboe@fb.com \
--cc=axboe@kernel.dk \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=edumazet@google.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sagi@grimberg.me \
--cc=willemb@google.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).