* [PATCH net] udp6: fix udp6_ehashfn() typo
@ 2023-07-08 8:29 Eric Dumazet
2023-07-08 14:29 ` Willem de Bruijn
2023-07-08 14:30 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Eric Dumazet @ 2023-07-08 8:29 UTC (permalink / raw)
To: David S . Miller, Jakub Kicinski, Paolo Abeni
Cc: netdev, eric.dumazet, Eric Dumazet, Amit Klein, Willy Tarreau,
Willem de Bruijn, David Ahern, Hannes Frederic Sowa
Amit Klein reported that udp6_ehash_secret was initialized but never used.
Fixes: 1bbdceef1e53 ("inet: convert inet_ehash_secret and ipv6_hash_secret to net_get_random_once")
Reported-by: Amit Klein <aksecurity@gmail.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Willy Tarreau <w@1wt.eu>
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: David Ahern <dsahern@kernel.org>
Cc: Hannes Frederic Sowa <hannes@stressinduktion.org>
---
net/ipv6/udp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv6/udp.c b/net/ipv6/udp.c
index 630d61a32c1df0bc222dfff2613585b2d416f839..b7c972aa09a75404e0edb33f0354c53702c991f8 100644
--- a/net/ipv6/udp.c
+++ b/net/ipv6/udp.c
@@ -91,7 +91,7 @@ static u32 udp6_ehashfn(const struct net *net,
fhash = __ipv6_addr_jhash(faddr, udp_ipv6_hash_secret);
return __inet6_ehashfn(lhash, lport, fhash, fport,
- udp_ipv6_hash_secret + net_hash_mix(net));
+ udp6_ehash_secret + net_hash_mix(net));
}
int udp_v6_get_port(struct sock *sk, unsigned short snum)
--
2.41.0.255.g8b1d071c50-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH net] udp6: fix udp6_ehashfn() typo
2023-07-08 8:29 [PATCH net] udp6: fix udp6_ehashfn() typo Eric Dumazet
@ 2023-07-08 14:29 ` Willem de Bruijn
2023-07-08 14:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Willem de Bruijn @ 2023-07-08 14:29 UTC (permalink / raw)
To: Eric Dumazet, David S . Miller, Jakub Kicinski, Paolo Abeni
Cc: netdev, eric.dumazet, Eric Dumazet, Amit Klein, Willy Tarreau,
Willem de Bruijn, David Ahern, Hannes Frederic Sowa
Eric Dumazet wrote:
> Amit Klein reported that udp6_ehash_secret was initialized but never used.
>
> Fixes: 1bbdceef1e53 ("inet: convert inet_ehash_secret and ipv6_hash_secret to net_get_random_once")
> Reported-by: Amit Klein <aksecurity@gmail.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Willy Tarreau <w@1wt.eu>
> Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
> Cc: David Ahern <dsahern@kernel.org>
> Cc: Hannes Frederic Sowa <hannes@stressinduktion.org>
Reviewed-by: Willem de Bruijn <willemb@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] udp6: fix udp6_ehashfn() typo
2023-07-08 8:29 [PATCH net] udp6: fix udp6_ehashfn() typo Eric Dumazet
2023-07-08 14:29 ` Willem de Bruijn
@ 2023-07-08 14:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-07-08 14:30 UTC (permalink / raw)
To: Eric Dumazet
Cc: davem, kuba, pabeni, netdev, eric.dumazet, aksecurity, w,
willemdebruijn.kernel, dsahern, hannes
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Sat, 8 Jul 2023 08:29:58 +0000 you wrote:
> Amit Klein reported that udp6_ehash_secret was initialized but never used.
>
> Fixes: 1bbdceef1e53 ("inet: convert inet_ehash_secret and ipv6_hash_secret to net_get_random_once")
> Reported-by: Amit Klein <aksecurity@gmail.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Willy Tarreau <w@1wt.eu>
> Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
> Cc: David Ahern <dsahern@kernel.org>
> Cc: Hannes Frederic Sowa <hannes@stressinduktion.org>
>
> [...]
Here is the summary with links:
- [net] udp6: fix udp6_ehashfn() typo
https://git.kernel.org/netdev/net/c/51d03e2f2203
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-08 14:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-08 8:29 [PATCH net] udp6: fix udp6_ehashfn() typo Eric Dumazet
2023-07-08 14:29 ` Willem de Bruijn
2023-07-08 14:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).