From: patchwork-bot+netdevbpf@kernel.org
To: Krister Johansen <kjlx@templeofstupid.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
shayagr@amazon.com, akiyano@amazon.com, darinzon@amazon.com,
ndagan@amazon.com, saeedb@amazon.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com
Subject: Re: [PATCH net] net: ena: fix shift-out-of-bounds in exponential backoff
Date: Wed, 12 Jul 2023 23:00:21 +0000 [thread overview]
Message-ID: <168920282162.4587.10421020284292608288.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230711013621.GE1926@templeofstupid.com>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 10 Jul 2023 18:36:21 -0700 you wrote:
> The ENA adapters on our instances occasionally reset. Once recently
> logged a UBSAN failure to console in the process:
>
> UBSAN: shift-out-of-bounds in build/linux/drivers/net/ethernet/amazon/ena/ena_com.c:540:13
> shift exponent 32 is too large for 32-bit type 'unsigned int'
> CPU: 28 PID: 70012 Comm: kworker/u72:2 Kdump: loaded not tainted 5.15.117
> Hardware name: Amazon EC2 c5d.9xlarge/, BIOS 1.0 10/16/2017
> Workqueue: ena ena_fw_reset_device [ena]
> Call Trace:
> <TASK>
> dump_stack_lvl+0x4a/0x63
> dump_stack+0x10/0x16
> ubsan_epilogue+0x9/0x36
> __ubsan_handle_shift_out_of_bounds.cold+0x61/0x10e
> ? __const_udelay+0x43/0x50
> ena_delay_exponential_backoff_us.cold+0x16/0x1e [ena]
> wait_for_reset_state+0x54/0xa0 [ena]
> ena_com_dev_reset+0xc8/0x110 [ena]
> ena_down+0x3fe/0x480 [ena]
> ena_destroy_device+0xeb/0xf0 [ena]
> ena_fw_reset_device+0x30/0x50 [ena]
> process_one_work+0x22b/0x3d0
> worker_thread+0x4d/0x3f0
> ? process_one_work+0x3d0/0x3d0
> kthread+0x12a/0x150
> ? set_kthread_struct+0x50/0x50
> ret_from_fork+0x22/0x30
> </TASK>
>
> [...]
Here is the summary with links:
- [net] net: ena: fix shift-out-of-bounds in exponential backoff
https://git.kernel.org/netdev/net/c/1e9cb763e9ba
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-07-12 23:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 1:36 [PATCH net] net: ena: fix shift-out-of-bounds in exponential backoff Krister Johansen
2023-07-11 7:26 ` Leon Romanovsky
2023-07-13 15:34 ` David Laight
2023-07-11 17:47 ` Shay Agroskin
2023-07-11 22:52 ` Krister Johansen
2023-07-13 7:46 ` Shay Agroskin
2023-07-14 0:05 ` Krister Johansen
2023-07-12 23:00 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168920282162.4587.10421020284292608288.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=akiyano@amazon.com \
--cc=darinzon@amazon.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kjlx@templeofstupid.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ndagan@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedb@amazon.com \
--cc=shayagr@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).