netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net v2] bna: Remove error checking for debugfs_create_dir()
@ 2023-07-13  9:51 Wang Ming
  2023-07-14  8:10 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Wang Ming @ 2023-07-13  9:51 UTC (permalink / raw)
  To: Rasesh Mody, Sudarsana Kalluru, GR-Linux-NIC-Dev, David S. Miller,
	Eric Dumazet, Jakub Kicinski, Paolo Abeni, netdev, linux-kernel
  Cc: opensource.kernel, rdunlap, Wang Ming

It is expected that most callers should _ignore_ the errors return by
debugfs_create_dir() in bnad_debugfs_init().

Signed-off-by: Wang Ming <machel@vivo.com>
---
 drivers/net/ethernet/brocade/bna/bnad_debugfs.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/net/ethernet/brocade/bna/bnad_debugfs.c b/drivers/net/ethernet/brocade/bna/bnad_debugfs.c
index 04ad0f2b9677..7246e13dd559 100644
--- a/drivers/net/ethernet/brocade/bna/bnad_debugfs.c
+++ b/drivers/net/ethernet/brocade/bna/bnad_debugfs.c
@@ -512,11 +512,6 @@ bnad_debugfs_init(struct bnad *bnad)
 	if (!bnad->port_debugfs_root) {
 		bnad->port_debugfs_root =
 			debugfs_create_dir(name, bna_debugfs_root);
-		if (!bnad->port_debugfs_root) {
-			netdev_warn(bnad->netdev,
-				    "debugfs root dir creation failed\n");
-			return;
-		}
 
 		atomic_inc(&bna_debugfs_port_count);
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net v2] bna: Remove error checking for debugfs_create_dir()
  2023-07-13  9:51 [PATCH net v2] bna: Remove error checking for debugfs_create_dir() Wang Ming
@ 2023-07-14  8:10 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-07-14  8:10 UTC (permalink / raw)
  To: =?utf-8?b?546L5piOLei9r+S7tuW6leWxguaKgOacr+mDqCA8bWFjaGVsQHZpdm8uY29tPg==?=
  Cc: rmody, skalluru, GR-Linux-NIC-Dev, davem, edumazet, kuba, pabeni,
	netdev, linux-kernel, opensource.kernel, rdunlap

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:

On Thu, 13 Jul 2023 17:51:06 +0800 you wrote:
> It is expected that most callers should _ignore_ the errors return by
> debugfs_create_dir() in bnad_debugfs_init().
> 
> Signed-off-by: Wang Ming <machel@vivo.com>
> ---
>  drivers/net/ethernet/brocade/bna/bnad_debugfs.c | 5 -----
>  1 file changed, 5 deletions(-)

Here is the summary with links:
  - [net,v2] bna: Remove error checking for debugfs_create_dir()
    https://git.kernel.org/netdev/net/c/4ad23d2368cc

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-07-14  8:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-13  9:51 [PATCH net v2] bna: Remove error checking for debugfs_create_dir() Wang Ming
2023-07-14  8:10 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).