* [PATCH net v1] net: ethernet: Remove repeating expression
@ 2023-07-13 12:16 Wang Ming
2023-07-14 1:47 ` Jiawen Wu
2023-07-14 8:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Wang Ming @ 2023-07-13 12:16 UTC (permalink / raw)
To: Jiawen Wu, Mengyuan Lou, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Wang Ming, netdev, linux-kernel
Cc: opensource.kernel
Identify issues that arise by using the tests/doublebitand.cocci
semantic patch. Need to remove duplicate expression in if statement.
Signed-off-by: Wang Ming <machel@vivo.com>
---
drivers/net/ethernet/wangxun/libwx/wx_hw.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/wangxun/libwx/wx_hw.c b/drivers/net/ethernet/wangxun/libwx/wx_hw.c
index 39a9aeee7aab..6321178fc814 100644
--- a/drivers/net/ethernet/wangxun/libwx/wx_hw.c
+++ b/drivers/net/ethernet/wangxun/libwx/wx_hw.c
@@ -1511,7 +1511,6 @@ static void wx_configure_rx(struct wx *wx)
psrtype = WX_RDB_PL_CFG_L4HDR |
WX_RDB_PL_CFG_L3HDR |
WX_RDB_PL_CFG_L2HDR |
- WX_RDB_PL_CFG_TUN_TUNHDR |
WX_RDB_PL_CFG_TUN_TUNHDR;
wr32(wx, WX_RDB_PL_CFG(0), psrtype);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH net v1] net: ethernet: Remove repeating expression
2023-07-13 12:16 [PATCH net v1] net: ethernet: Remove repeating expression Wang Ming
@ 2023-07-14 1:47 ` Jiawen Wu
2023-07-14 8:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Jiawen Wu @ 2023-07-14 1:47 UTC (permalink / raw)
To: 'Wang Ming', 'Mengyuan Lou',
'David S. Miller', 'Eric Dumazet',
'Jakub Kicinski', 'Paolo Abeni', netdev,
linux-kernel, 'Mengyuan Lou', 'David S. Miller',
'Eric Dumazet', 'Jakub Kicinski',
'Paolo Abeni', netdev, linux-kernel
Cc: opensource.kernel, opensource.kernel
On Thursday, July 13, 2023 8:16 PM, Wang Ming wrote:
> Identify issues that arise by using the tests/doublebitand.cocci
> semantic patch. Need to remove duplicate expression in if statement.
>
> Signed-off-by: Wang Ming <machel@vivo.com>
> ---
> drivers/net/ethernet/wangxun/libwx/wx_hw.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/wangxun/libwx/wx_hw.c b/drivers/net/ethernet/wangxun/libwx/wx_hw.c
> index 39a9aeee7aab..6321178fc814 100644
> --- a/drivers/net/ethernet/wangxun/libwx/wx_hw.c
> +++ b/drivers/net/ethernet/wangxun/libwx/wx_hw.c
> @@ -1511,7 +1511,6 @@ static void wx_configure_rx(struct wx *wx)
> psrtype = WX_RDB_PL_CFG_L4HDR |
> WX_RDB_PL_CFG_L3HDR |
> WX_RDB_PL_CFG_L2HDR |
> - WX_RDB_PL_CFG_TUN_TUNHDR |
> WX_RDB_PL_CFG_TUN_TUNHDR;
> wr32(wx, WX_RDB_PL_CFG(0), psrtype);
Reviewed-by: Jiawen Wu <jiawenwu@trustnetic.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net v1] net: ethernet: Remove repeating expression
2023-07-13 12:16 [PATCH net v1] net: ethernet: Remove repeating expression Wang Ming
2023-07-14 1:47 ` Jiawen Wu
@ 2023-07-14 8:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-07-14 8:20 UTC (permalink / raw)
To: =?utf-8?b?546L5piOLei9r+S7tuW6leWxguaKgOacr+mDqCA8bWFjaGVsQHZpdm8uY29tPg==?=
Cc: jiawenwu, mengyuanlou, davem, edumazet, kuba, pabeni, netdev,
linux-kernel, opensource.kernel
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Thu, 13 Jul 2023 20:16:03 +0800 you wrote:
> Identify issues that arise by using the tests/doublebitand.cocci
> semantic patch. Need to remove duplicate expression in if statement.
>
> Signed-off-by: Wang Ming <machel@vivo.com>
> ---
> drivers/net/ethernet/wangxun/libwx/wx_hw.c | 1 -
> 1 file changed, 1 deletion(-)
Here is the summary with links:
- [net,v1] net: ethernet: Remove repeating expression
https://git.kernel.org/netdev/net/c/a822551c51f0
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-14 8:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-13 12:16 [PATCH net v1] net: ethernet: Remove repeating expression Wang Ming
2023-07-14 1:47 ` Jiawen Wu
2023-07-14 8:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).