[PATCH 0/1] pull request (net-next): ipsec-next 2023-07-19

[PATCH 0/1] pull request (net-next): ipsec-next 2023-07-19

[Steffen Klassert]

Just a leftover from the last development cycle:

1) delete a clear to zero of encap_oa, it is not needed anymore.
   From Leon Romanovsky.

Please pull or let me know if there are problems.

Thanks!

The following changes since commit b2cbac9b9b28730e9e53be20b6cdf979d3b9f27e:

  net: Remove low_thresh in ip defrag (2023-05-15 08:42:07 +0100)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next.git tags/ipsec-next-2023-07-19

for you to fetch changes up to a94fd40a18ae76ba76dbaa8eca0e3c46aa1142c1:

  xfrm: delete not-needed clear to zero of encap_oa (2023-06-09 09:19:11 +0200)

----------------------------------------------------------------
ipsec-next-2023-07-19

----------------------------------------------------------------
Leon Romanovsky (1):
      xfrm: delete not-needed clear to zero of encap_oa

 net/key/af_key.c | 1 -
 1 file changed, 1 deletion(-)

[PATCH] xfrm: delete not-needed clear to zero of encap_oa

[Steffen Klassert]

From: Leon Romanovsky <leonro@nvidia.com>

After commit 2f4796518315 ("af_key: Fix heap information leak"), there is
no need to clear encap_oa again as it is already initialized to zero.

Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
---
 net/key/af_key.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/key/af_key.c b/net/key/af_key.c
index a815f5ab4c49..1cb4560afd44 100644
--- a/net/key/af_key.c
+++ b/net/key/af_key.c
@@ -1281,7 +1281,6 @@ static struct xfrm_state * pfkey_msg2xfrm_state(struct net *net,
 				ext_hdrs[SADB_X_EXT_NAT_T_DPORT-1];
 			natt->encap_dport = n_port->sadb_x_nat_t_port_port;
 		}
-		memset(&natt->encap_oa, 0, sizeof(natt->encap_oa));
 	}
 
 	err = xfrm_init_state(x);
-- 
2.34.1

Re: [PATCH] xfrm: delete not-needed clear to zero of encap_oa

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Steffen Klassert <steffen.klassert@secunet.com>:

On Wed, 19 Jul 2023 12:02:28 +0200 you wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
> 
> After commit 2f4796518315 ("af_key: Fix heap information leak"), there is
> no need to clear encap_oa again as it is already initialized to zero.
> 
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> Reviewed-by: Simon Horman <simon.horman@corigine.com>
> Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
> 
> [...]

Here is the summary with links:
  - xfrm: delete not-needed clear to zero of encap_oa
    https://git.kernel.org/netdev/net-next/c/a94fd40a18ae

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html