netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net] bcmasp: BCMASP should depend on ARCH_BRCMSTB
@ 2023-07-25 15:46 Geert Uytterhoeven
  2023-07-25 15:55 ` Simon Horman
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2023-07-25 15:46 UTC (permalink / raw)
  To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Florian Fainelli, Justin Chen, Simon Horman
  Cc: netdev, linux-kernel, Geert Uytterhoeven

The Broadcom ASP 2.0 Ethernet controller is only present on Broadcom STB
SoCs.  Hence add a dependency on ARCH_BRCMSTB, to prevent asking the
user about this driver when configuring a kernel without Broadcom
ARM-based set-top box chipset support.

Fixes: 490cb412007de593 ("net: bcmasp: Add support for ASP2.0 Ethernet controller")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/net/ethernet/broadcom/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/broadcom/Kconfig
index d4166141145d631c..75ca3ddda1f5e09f 100644
--- a/drivers/net/ethernet/broadcom/Kconfig
+++ b/drivers/net/ethernet/broadcom/Kconfig
@@ -257,6 +257,7 @@ config BNXT_HWMON
 
 config BCMASP
 	tristate "Broadcom ASP 2.0 Ethernet support"
+	depends on ARCH_BRCMSTB || COMPILE_TEST
 	default ARCH_BRCMSTB
 	depends on OF
 	select MII
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH net] bcmasp: BCMASP should depend on ARCH_BRCMSTB
  2023-07-25 15:46 [PATCH net] bcmasp: BCMASP should depend on ARCH_BRCMSTB Geert Uytterhoeven
@ 2023-07-25 15:55 ` Simon Horman
  2023-07-25 16:08 ` Florian Fainelli
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2023-07-25 15:55 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Florian Fainelli, Justin Chen, netdev, linux-kernel

On Tue, Jul 25, 2023 at 05:46:37PM +0200, Geert Uytterhoeven wrote:
> The Broadcom ASP 2.0 Ethernet controller is only present on Broadcom STB
> SoCs.  Hence add a dependency on ARCH_BRCMSTB, to prevent asking the
> user about this driver when configuring a kernel without Broadcom
> ARM-based set-top box chipset support.
> 
> Fixes: 490cb412007de593 ("net: bcmasp: Add support for ASP2.0 Ethernet controller")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Simon Horman <simon.horman@corigine.com>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH net] bcmasp: BCMASP should depend on ARCH_BRCMSTB
  2023-07-25 15:46 [PATCH net] bcmasp: BCMASP should depend on ARCH_BRCMSTB Geert Uytterhoeven
  2023-07-25 15:55 ` Simon Horman
@ 2023-07-25 16:08 ` Florian Fainelli
  2023-07-25 20:35 ` Justin Chen
  2023-07-27  4:50 ` patchwork-bot+netdevbpf
  3 siblings, 0 replies; 5+ messages in thread
From: Florian Fainelli @ 2023-07-25 16:08 UTC (permalink / raw)
  To: Geert Uytterhoeven, David S . Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Justin Chen, Simon Horman
  Cc: netdev, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 528 bytes --]



On 7/25/2023 8:46 AM, Geert Uytterhoeven wrote:
> The Broadcom ASP 2.0 Ethernet controller is only present on Broadcom STB
> SoCs.  Hence add a dependency on ARCH_BRCMSTB, to prevent asking the
> user about this driver when configuring a kernel without Broadcom
> ARM-based set-top box chipset support.
> 
> Fixes: 490cb412007de593 ("net: bcmasp: Add support for ASP2.0 Ethernet controller")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Acked-by: Florian Fainelli <florian.fainelli@broadcom.com>
-- 
Florian

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH net] bcmasp: BCMASP should depend on ARCH_BRCMSTB
  2023-07-25 15:46 [PATCH net] bcmasp: BCMASP should depend on ARCH_BRCMSTB Geert Uytterhoeven
  2023-07-25 15:55 ` Simon Horman
  2023-07-25 16:08 ` Florian Fainelli
@ 2023-07-25 20:35 ` Justin Chen
  2023-07-27  4:50 ` patchwork-bot+netdevbpf
  3 siblings, 0 replies; 5+ messages in thread
From: Justin Chen @ 2023-07-25 20:35 UTC (permalink / raw)
  To: Geert Uytterhoeven, David S . Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Florian Fainelli, Simon Horman
  Cc: netdev, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1050 bytes --]



On 7/25/23 8:46 AM, Geert Uytterhoeven wrote:
> The Broadcom ASP 2.0 Ethernet controller is only present on Broadcom STB
> SoCs.  Hence add a dependency on ARCH_BRCMSTB, to prevent asking the
> user about this driver when configuring a kernel without Broadcom
> ARM-based set-top box chipset support.
> 
> Fixes: 490cb412007de593 ("net: bcmasp: Add support for ASP2.0 Ethernet controller")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Acked-by: Justin Chen <justin.chen@broadcom.com>

> ---
>   drivers/net/ethernet/broadcom/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/broadcom/Kconfig
> index d4166141145d631c..75ca3ddda1f5e09f 100644
> --- a/drivers/net/ethernet/broadcom/Kconfig
> +++ b/drivers/net/ethernet/broadcom/Kconfig
> @@ -257,6 +257,7 @@ config BNXT_HWMON
>   
>   config BCMASP
>   	tristate "Broadcom ASP 2.0 Ethernet support"
> +	depends on ARCH_BRCMSTB || COMPILE_TEST
>   	default ARCH_BRCMSTB
>   	depends on OF
>   	select MII

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4206 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH net] bcmasp: BCMASP should depend on ARCH_BRCMSTB
  2023-07-25 15:46 [PATCH net] bcmasp: BCMASP should depend on ARCH_BRCMSTB Geert Uytterhoeven
                   ` (2 preceding siblings ...)
  2023-07-25 20:35 ` Justin Chen
@ 2023-07-27  4:50 ` patchwork-bot+netdevbpf
  3 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-07-27  4:50 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: davem, edumazet, kuba, pabeni, florian.fainelli, justin.chen,
	simon.horman, netdev, linux-kernel

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 25 Jul 2023 17:46:37 +0200 you wrote:
> The Broadcom ASP 2.0 Ethernet controller is only present on Broadcom STB
> SoCs.  Hence add a dependency on ARCH_BRCMSTB, to prevent asking the
> user about this driver when configuring a kernel without Broadcom
> ARM-based set-top box chipset support.
> 
> Fixes: 490cb412007de593 ("net: bcmasp: Add support for ASP2.0 Ethernet controller")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> [...]

Here is the summary with links:
  - [net] bcmasp: BCMASP should depend on ARCH_BRCMSTB
    https://git.kernel.org/netdev/net-next/c/73365fe44aa5

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-07-27  4:50 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-25 15:46 [PATCH net] bcmasp: BCMASP should depend on ARCH_BRCMSTB Geert Uytterhoeven
2023-07-25 15:55 ` Simon Horman
2023-07-25 16:08 ` Florian Fainelli
2023-07-25 20:35 ` Justin Chen
2023-07-27  4:50 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).