netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] dt-bindings: net: qca,ar803x: add missing unevaluatedProperties for each regulator
@ 2023-07-25 12:37 Krzysztof Kozlowski
  2023-07-25 20:01 ` Conor Dooley
  2023-07-27  4:50 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-25 12:37 UTC (permalink / raw)
  To: Andrew Lunn, Heiner Kallweit, Russell King, David S. Miller,
	Eric Dumazet, Jakub Kicinski, Paolo Abeni, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Florian Fainelli, netdev,
	devicetree, linux-kernel
  Cc: Krzysztof Kozlowski

Each regulator node, which references common regulator.yaml schema,
should disallow additional or unevaluated properties.  Otherwise
mistakes in properties will go unnoticed.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/net/qca,ar803x.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/qca,ar803x.yaml b/Documentation/devicetree/bindings/net/qca,ar803x.yaml
index 161d28919316..3acd09f0da86 100644
--- a/Documentation/devicetree/bindings/net/qca,ar803x.yaml
+++ b/Documentation/devicetree/bindings/net/qca,ar803x.yaml
@@ -75,6 +75,7 @@ properties:
     description:
       Initial data for the VDDIO regulator. Set this to 1.5V or 1.8V.
     $ref: /schemas/regulator/regulator.yaml
+    unevaluatedProperties: false
 
   vddh-regulator:
     type: object
@@ -82,6 +83,7 @@ properties:
       Dummy subnode to model the external connection of the PHY VDDH
       regulator to VDDIO.
     $ref: /schemas/regulator/regulator.yaml
+    unevaluatedProperties: false
 
 unevaluatedProperties: false
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] dt-bindings: net: qca,ar803x: add missing unevaluatedProperties for each regulator
  2023-07-25 12:37 [PATCH net-next] dt-bindings: net: qca,ar803x: add missing unevaluatedProperties for each regulator Krzysztof Kozlowski
@ 2023-07-25 20:01 ` Conor Dooley
  2023-07-27  4:50 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Conor Dooley @ 2023-07-25 20:01 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Andrew Lunn, Heiner Kallweit, Russell King, David S. Miller,
	Eric Dumazet, Jakub Kicinski, Paolo Abeni, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Florian Fainelli, netdev,
	devicetree, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1341 bytes --]

On Tue, Jul 25, 2023 at 02:37:11PM +0200, Krzysztof Kozlowski wrote:
> Each regulator node, which references common regulator.yaml schema,
> should disallow additional or unevaluated properties.  Otherwise
> mistakes in properties will go unnoticed.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Acked-by: Conor Dooley <conor.dooley@microchip.com>


> ---
>  Documentation/devicetree/bindings/net/qca,ar803x.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/qca,ar803x.yaml b/Documentation/devicetree/bindings/net/qca,ar803x.yaml
> index 161d28919316..3acd09f0da86 100644
> --- a/Documentation/devicetree/bindings/net/qca,ar803x.yaml
> +++ b/Documentation/devicetree/bindings/net/qca,ar803x.yaml
> @@ -75,6 +75,7 @@ properties:
>      description:
>        Initial data for the VDDIO regulator. Set this to 1.5V or 1.8V.
>      $ref: /schemas/regulator/regulator.yaml
> +    unevaluatedProperties: false
>  
>    vddh-regulator:
>      type: object
> @@ -82,6 +83,7 @@ properties:
>        Dummy subnode to model the external connection of the PHY VDDH
>        regulator to VDDIO.
>      $ref: /schemas/regulator/regulator.yaml
> +    unevaluatedProperties: false
>  
>  unevaluatedProperties: false
>  
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] dt-bindings: net: qca,ar803x: add missing unevaluatedProperties for each regulator
  2023-07-25 12:37 [PATCH net-next] dt-bindings: net: qca,ar803x: add missing unevaluatedProperties for each regulator Krzysztof Kozlowski
  2023-07-25 20:01 ` Conor Dooley
@ 2023-07-27  4:50 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-07-27  4:50 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: andrew, hkallweit1, linux, davem, edumazet, kuba, pabeni, robh+dt,
	krzysztof.kozlowski+dt, conor+dt, f.fainelli, netdev, devicetree,
	linux-kernel

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 25 Jul 2023 14:37:11 +0200 you wrote:
> Each regulator node, which references common regulator.yaml schema,
> should disallow additional or unevaluated properties.  Otherwise
> mistakes in properties will go unnoticed.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/net/qca,ar803x.yaml | 2 ++
>  1 file changed, 2 insertions(+)

Here is the summary with links:
  - [net-next] dt-bindings: net: qca,ar803x: add missing unevaluatedProperties for each regulator
    https://git.kernel.org/netdev/net-next/c/c1b0b6118b48

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-07-27  4:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-25 12:37 [PATCH net-next] dt-bindings: net: qca,ar803x: add missing unevaluatedProperties for each regulator Krzysztof Kozlowski
2023-07-25 20:01 ` Conor Dooley
2023-07-27  4:50 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).