From: patchwork-bot+netdevbpf@kernel.org
To: Lin Ma <linma@zju.edu.cn>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, razor@blackwall.org, idosch@nvidia.com,
lucien.xin@gmail.com, liuhangbin@gmail.com,
edwin.peer@broadcom.com, jiri@resnulli.us,
md.fahad.iqbal.polash@intel.com,
anirudh.venkataramanan@intel.com, jeffrey.t.kirsher@intel.com,
neerav.parikh@intel.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v3] rtnetlink: let rtnl_bridge_setlink checks IFLA_BRIDGE_MODE length
Date: Fri, 28 Jul 2023 00:20:20 +0000 [thread overview]
Message-ID: <169050362043.24970.11385005356994975493.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230726075314.1059224-1-linma@zju.edu.cn>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 26 Jul 2023 15:53:14 +0800 you wrote:
> There are totally 9 ndo_bridge_setlink handlers in the current kernel,
> which are 1) bnxt_bridge_setlink, 2) be_ndo_bridge_setlink 3)
> i40e_ndo_bridge_setlink 4) ice_bridge_setlink 5)
> ixgbe_ndo_bridge_setlink 6) mlx5e_bridge_setlink 7)
> nfp_net_bridge_setlink 8) qeth_l2_bridge_setlink 9) br_setlink.
>
> By investigating the code, we find that 1-7 parse and use nlattr
> IFLA_BRIDGE_MODE but 3 and 4 forget to do the nla_len check. This can
> lead to an out-of-attribute read and allow a malformed nlattr (e.g.,
> length 0) to be viewed as a 2 byte integer.
>
> [...]
Here is the summary with links:
- [net,v3] rtnetlink: let rtnl_bridge_setlink checks IFLA_BRIDGE_MODE length
https://git.kernel.org/netdev/net/c/d73ef2d69c0d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-07-28 0:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 7:53 [PATCH net v3] rtnetlink: let rtnl_bridge_setlink checks IFLA_BRIDGE_MODE length Lin Ma
2023-07-26 9:29 ` Hangbin Liu
2023-07-28 0:15 ` Jakub Kicinski
2023-07-28 6:49 ` Lin Ma
2023-07-28 0:20 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169050362043.24970.11385005356994975493.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=anirudh.venkataramanan@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=edwin.peer@broadcom.com \
--cc=idosch@nvidia.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linma@zju.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=lucien.xin@gmail.com \
--cc=md.fahad.iqbal.polash@intel.com \
--cc=neerav.parikh@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox