[PATCH -next] net: bcmasp: Clean up redundant dev_err_probe()

[PATCH -next] net: bcmasp: Clean up redundant dev_err_probe()

[Chen Jiahao]

Refering to platform_get_irq()'s definition, the return value has
already been checked, error message also been printed via
dev_err_probe() if ret < 0. Calling dev_err_probe() one more time
outside platform_get_irq() is obviously redundant.

Removing dev_err_probe() outside platform_get_irq() to clean up
above problem.

Signed-off-by: Chen Jiahao <chenjiahao16@huawei.com>
---
 drivers/net/ethernet/broadcom/asp2/bcmasp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/broadcom/asp2/bcmasp.c b/drivers/net/ethernet/broadcom/asp2/bcmasp.c
index a9984efff6d1..eb35ced1c8ba 100644
--- a/drivers/net/ethernet/broadcom/asp2/bcmasp.c
+++ b/drivers/net/ethernet/broadcom/asp2/bcmasp.c
@@ -1232,7 +1232,7 @@ static int bcmasp_probe(struct platform_device *pdev)
 
 	priv->irq = platform_get_irq(pdev, 0);
 	if (priv->irq <= 0)
-		return dev_err_probe(dev, -EINVAL, "invalid interrupt\n");
+		return -EINVAL;
 
 	priv->clk = devm_clk_get_optional_enabled(dev, "sw_asp");
 	if (IS_ERR(priv->clk))
-- 
2.34.1

Re: [PATCH -next] net: bcmasp: Clean up redundant dev_err_probe()

[Simon Horman]

On Thu, Jul 27, 2023 at 07:55:51PM +0800, Chen Jiahao wrote:
> Refering to platform_get_irq()'s definition, the return value has

nit: Refering -> Referring

> already been checked, error message also been printed via
> dev_err_probe() if ret < 0. Calling dev_err_probe() one more time
> outside platform_get_irq() is obviously redundant.
> 
> Removing dev_err_probe() outside platform_get_irq() to clean up
> above problem.
> 
> Signed-off-by: Chen Jiahao <chenjiahao16@huawei.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>

Re: [PATCH -next] net: bcmasp: Clean up redundant dev_err_probe()

[chenjiahao (C)]

On 2023/7/27 21:32, Simon Horman wrote:
> On Thu, Jul 27, 2023 at 07:55:51PM +0800, Chen Jiahao wrote:
>> Refering to platform_get_irq()'s definition, the return value has
> nit: Refering -> Referring

Thanks, I will fix this typo in v2 patch if needed.

Jiahao

>
>> already been checked, error message also been printed via
>> dev_err_probe() if ret < 0. Calling dev_err_probe() one more time
>> outside platform_get_irq() is obviously redundant.
>>
>> Removing dev_err_probe() outside platform_get_irq() to clean up
>> above problem.
>>
>> Signed-off-by: Chen Jiahao <chenjiahao16@huawei.com>
> Reviewed-by: Simon Horman <simon.horman@corigine.com>
>

Re: [PATCH -next] net: bcmasp: Clean up redundant dev_err_probe()

[Justin Chen]

[-- Attachment #1: Type: text/plain, Size: 1183 bytes --]



On 7/27/23 4:55 AM, Chen Jiahao wrote:
> Refering to platform_get_irq()'s definition, the return value has
> already been checked, error message also been printed via
> dev_err_probe() if ret < 0. Calling dev_err_probe() one more time
> outside platform_get_irq() is obviously redundant.
> 
> Removing dev_err_probe() outside platform_get_irq() to clean up
> above problem.
> 
> Signed-off-by: Chen Jiahao <chenjiahao16@huawei.com>

Acked-by: Justin Chen <justin.chen@broadcom.com>

> ---
>   drivers/net/ethernet/broadcom/asp2/bcmasp.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/asp2/bcmasp.c b/drivers/net/ethernet/broadcom/asp2/bcmasp.c
> index a9984efff6d1..eb35ced1c8ba 100644
> --- a/drivers/net/ethernet/broadcom/asp2/bcmasp.c
> +++ b/drivers/net/ethernet/broadcom/asp2/bcmasp.c
> @@ -1232,7 +1232,7 @@ static int bcmasp_probe(struct platform_device *pdev)
>   
>   	priv->irq = platform_get_irq(pdev, 0);
>   	if (priv->irq <= 0)
> -		return dev_err_probe(dev, -EINVAL, "invalid interrupt\n");
> +		return -EINVAL;
>   
>   	priv->clk = devm_clk_get_optional_enabled(dev, "sw_asp");
>   	if (IS_ERR(priv->clk))

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4206 bytes --]

Re: [PATCH -next] net: bcmasp: Clean up redundant dev_err_probe()

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 27 Jul 2023 19:55:51 +0800 you wrote:
> Refering to platform_get_irq()'s definition, the return value has
> already been checked, error message also been printed via
> dev_err_probe() if ret < 0. Calling dev_err_probe() one more time
> outside platform_get_irq() is obviously redundant.
> 
> Removing dev_err_probe() outside platform_get_irq() to clean up
> above problem.
> 
> [...]

Here is the summary with links:
  - [-next] net: bcmasp: Clean up redundant dev_err_probe()
    https://git.kernel.org/netdev/net-next/c/c88c157d25d9

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html