[PATCH v1 net] selftest: net: Assert on a proper value in so_incoming_cpu.c.

[PATCH v1 net] selftest: net: Assert on a proper value in so_incoming_cpu.c.

[Kuniyuki Iwashima]

Dan Carpenter reported an error spotted by Smatch.

  ./tools/testing/selftests/net/so_incoming_cpu.c:163 create_clients()
  error: uninitialized symbol 'ret'.

The returned value of sched_setaffinity() should be checked with
ASSERT_EQ(), but the value was not saved in a proper variable,
resulting in an error above.

Let's save the returned value of with sched_setaffinity().

Fixes: 6df96146b202 ("selftest: Add test for SO_INCOMING_CPU.")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/linux-kselftest/fe376760-33b6-4fc9-88e8-178e809af1ac@moroto.mountain/
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
---
 tools/testing/selftests/net/so_incoming_cpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/so_incoming_cpu.c b/tools/testing/selftests/net/so_incoming_cpu.c
index 0e04f9fef986..a14818164102 100644
--- a/tools/testing/selftests/net/so_incoming_cpu.c
+++ b/tools/testing/selftests/net/so_incoming_cpu.c
@@ -159,7 +159,7 @@ void create_clients(struct __test_metadata *_metadata,
 		/* Make sure SYN will be processed on the i-th CPU
 		 * and finally distributed to the i-th listener.
 		 */
-		sched_setaffinity(0, sizeof(cpu_set), &cpu_set);
+		ret = sched_setaffinity(0, sizeof(cpu_set), &cpu_set);
 		ASSERT_EQ(ret, 0);
 
 		for (j = 0; j < CLIENT_PER_SERVER; j++) {
-- 
2.30.2

Re: [PATCH v1 net] selftest: net: Assert on a proper value in so_incoming_cpu.c.

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 31 Jul 2023 11:15:53 -0700 you wrote:
> Dan Carpenter reported an error spotted by Smatch.
> 
>   ./tools/testing/selftests/net/so_incoming_cpu.c:163 create_clients()
>   error: uninitialized symbol 'ret'.
> 
> The returned value of sched_setaffinity() should be checked with
> ASSERT_EQ(), but the value was not saved in a proper variable,
> resulting in an error above.
> 
> [...]

Here is the summary with links:
  - [v1,net] selftest: net: Assert on a proper value in so_incoming_cpu.c.
    https://git.kernel.org/netdev/net/c/3ff1617450ec

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html