From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8C48566E for ; Wed, 2 Aug 2023 09:20:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 4A41FC433C9; Wed, 2 Aug 2023 09:20:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690968021; bh=K+scnvFOeZn+qs2Y4uK06yD8U/KPe7In361cfN7JZ5Q=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=gtXV1xyVIRPuM2jjLJrAvZM7fBS93gqGVuaSfcB+sbAm/Oqy5uKzzDYW7px93JkEa WBwnNpR8lL3bvsXTCX2z3Yw43EmcSNST44ZYeAYivCnc7MGX0M4npdDCB367GA38RM jUsRZDSqqdvPn16WiQmdDOBlZX5+kOx2h07OMIUWNqiNz7yG0BPw9NWUObiwX0d9Wa CguUzHcCB9iQcIwV39DTY70b9mENDhJaLc1QVUMFEcTE4wcb+AUWhfiqJTnXmQ+sxW 1XU9AhYncRQwDKQlJdxwqidyZpmoeQpWXpXiE55SpdnWr7ELAkxs6L9UBS8ItOcfSF hvAQztgyenI6g== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 28D53C6445A; Wed, 2 Aug 2023 09:20:21 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net] s390/qeth: Don't call dev_close/dev_open (DOWN/UP) From: patchwork-bot+netdevbpf@kernel.org Message-Id: <169096802115.5600.7801745258990045314.git-patchwork-notify@kernel.org> Date: Wed, 02 Aug 2023 09:20:21 +0000 References: <20230801080016.744474-1-wintera@linux.ibm.com> In-Reply-To: <20230801080016.744474-1-wintera@linux.ibm.com> To: Alexandra Winter Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com, netdev@vger.kernel.org, linux-s390@vger.kernel.org, hca@linux.ibm.com, wenjia@linux.ibm.com Hello: This patch was applied to netdev/net.git (main) by David S. Miller : On Tue, 1 Aug 2023 10:00:16 +0200 you wrote: > dev_close() and dev_open() are issued to change the interface state to DOWN > or UP (dev->flags IFF_UP). When the netdev is set DOWN it loses e.g its > Ipv6 addresses and routes. We don't want this in cases of device recovery > (triggered by hardware or software) or when the qeth device is set > offline. > > Setting a qeth device offline or online and device recovery actions call > netif_device_detach() and/or netif_device_attach(). That will reset or > set the LOWER_UP indication i.e. change the dev->state Bit > __LINK_STATE_PRESENT. That is enough to e.g. cause bond failovers, and > still preserves the interface settings that are handled by the network > stack. > > [...] Here is the summary with links: - [net] s390/qeth: Don't call dev_close/dev_open (DOWN/UP) https://git.kernel.org/netdev/net/c/1cfef80d4c2b You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html