[PATCH -next] af_vsock: Remove unused declaration vsock_release_pending()/vsock_init_tap()

[PATCH -next] af_vsock: Remove unused declaration vsock_release_pending()/vsock_init_tap()

[Yue Haibing]

Commit d021c344051a ("VSOCK: Introduce VM Sockets") declared but never implemented
vsock_release_pending(). Also vsock_init_tap() never implemented since introduction
in commit 531b374834c8 ("VSOCK: Add vsockmon tap functions").

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
 include/net/af_vsock.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/include/net/af_vsock.h b/include/net/af_vsock.h
index 0e7504a42925..b01cf9ac2437 100644
--- a/include/net/af_vsock.h
+++ b/include/net/af_vsock.h
@@ -201,7 +201,6 @@ static inline bool __vsock_in_connected_table(struct vsock_sock *vsk)
 	return !list_empty(&vsk->connected_table);
 }
 
-void vsock_release_pending(struct sock *pending);
 void vsock_add_pending(struct sock *listener, struct sock *pending);
 void vsock_remove_pending(struct sock *listener, struct sock *pending);
 void vsock_enqueue_accept(struct sock *listener, struct sock *connected);
@@ -225,7 +224,6 @@ struct vsock_tap {
 	struct list_head list;
 };
 
-int vsock_init_tap(void);
 int vsock_add_tap(struct vsock_tap *vt);
 int vsock_remove_tap(struct vsock_tap *vt);
 void vsock_deliver_tap(struct sk_buff *build_skb(void *opaque), void *opaque);
-- 
2.34.1

Re: [PATCH -next] af_vsock: Remove unused declaration vsock_release_pending()/vsock_init_tap()

[Simon Horman]

On Thu, Aug 03, 2023 at 09:45:07PM +0800, Yue Haibing wrote:
> Commit d021c344051a ("VSOCK: Introduce VM Sockets") declared but never implemented
> vsock_release_pending(). Also vsock_init_tap() never implemented since introduction
> in commit 531b374834c8 ("VSOCK: Add vsockmon tap functions").
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>

Hi Yue Haibing,

FWIIW, I think this should be targeted at net-next.
In any case, the change looks good to me.

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH -next] af_vsock: Remove unused declaration vsock_release_pending()/vsock_init_tap()

[Stefano Garzarella]

On Thu, Aug 03, 2023 at 09:33:41PM +0200, Simon Horman wrote:
>On Thu, Aug 03, 2023 at 09:45:07PM +0800, Yue Haibing wrote:
>> Commit d021c344051a ("VSOCK: Introduce VM Sockets") declared but never implemented
>> vsock_release_pending(). Also vsock_init_tap() never implemented since introduction
>> in commit 531b374834c8 ("VSOCK: Add vsockmon tap functions").
>>
>> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
>
>Hi Yue Haibing,
>
>FWIIW, I think this should be targeted at net-next.

Yep, please send to net-next.

Looks good also to me:

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>

Re: [PATCH -next] af_vsock: Remove unused declaration vsock_release_pending()/vsock_init_tap()

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 3 Aug 2023 21:45:07 +0800 you wrote:
> Commit d021c344051a ("VSOCK: Introduce VM Sockets") declared but never implemented
> vsock_release_pending(). Also vsock_init_tap() never implemented since introduction
> in commit 531b374834c8 ("VSOCK: Add vsockmon tap functions").
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
>  include/net/af_vsock.h | 2 --
>  1 file changed, 2 deletions(-)

Here is the summary with links:
  - [-next] af_vsock: Remove unused declaration vsock_release_pending()/vsock_init_tap()
    https://git.kernel.org/netdev/net-next/c/781486e415dc

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html